Skip to content

fix[components][sfud]: 修复日志输出的gcc编译警告 #10800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix[components][sfud]: 修复日志输出的gcc编译警告 #10800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions components/dfs/dfs_v1/src/dfs_fs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ int dfs_filesystem_get_partition(struct dfs_partition *part,
part->offset = *(dpt + 8) | *(dpt + 9) << 8 | *(dpt + 10) << 16 | *(dpt + 11) << 24;
part->size = *(dpt + 12) | *(dpt + 13) << 8 | *(dpt + 14) << 16 | *(dpt + 15) << 24;

rt_kprintf("found part[%d], begin: %d, size: ",
rt_kprintf("found part[%ld], begin: %ld, size: ",
pindex, part->offset * 512);
if ((part->size >> 11) == 0)
rt_kprintf("%d%s", part->size >> 1, "KB\n"); /* KB */
Copy link

Copilot AI Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug/错误: The format specifier should be updated to %ld to match the part->size data type, which appears to be a long integer based on the pattern used elsewhere in this file. 格式说明符应该更新为 %ld 以匹配 part->size 数据类型，根据此文件中其他地方使用的模式，它似乎是长整型。

Suggested change
rt_kprintf("%d%s", part->size >> 1, "KB\n"); /* KB */
rt_kprintf("%ld%s", part->size >> 1, "KB\n"); /* KB */

Copilot uses AI. Check for mistakes.

Expand Down Expand Up @@ -636,7 +636,7 @@ int df(const char *path)
if (rt_get_errno() == -ENOSYS)
rt_kprintf("The function is not implemented.\n");
else
rt_kprintf("statfs failed: errno=%d.\n", rt_get_errno());
rt_kprintf("statfs failed: errno=%ld.\n", rt_get_errno());
return -1;
}

Expand All @@ -649,7 +649,7 @@ int df(const char *path)
cap = cap / 1024;
}

rt_kprintf("disk free: %d.%d %s [ %d block, %d bytes per block ]\n",
rt_kprintf("disk free: %ld.%d %s [ %d block, %d bytes per block ]\n",
(unsigned long)cap, minor, unit_str[unit_index], buffer.f_bfree, buffer.f_bsize);
return 0;
}
Expand Down
22 changes: 11 additions & 11 deletions components/drivers/spi/dev_spi_flash_sfud.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,9 +569,9 @@ static void sf(uint8_t argc, char **argv) {

sfud_dev = (sfud_flash_t)rtt_dev->user_data;
if (sfud_dev->chip.capacity < 1024 * 1024) {
rt_kprintf("%d KB %s is current selected device.\n", sfud_dev->chip.capacity / 1024, sfud_dev->name);
rt_kprintf("%ld KB %s is current selected device.\n", sfud_dev->chip.capacity / 1024, sfud_dev->name);
} else {
rt_kprintf("%d MB %s is current selected device.\n", sfud_dev->chip.capacity / 1024 / 1024,
rt_kprintf("%ld MB %s is current selected device.\n", sfud_dev->chip.capacity / 1024 / 1024,
sfud_dev->name);
}
}
Expand All @@ -591,12 +591,12 @@ static void sf(uint8_t argc, char **argv) {
if (data) {
result = sfud_read(sfud_dev, addr, size, data);
if (result == SFUD_SUCCESS) {
rt_kprintf("Read the %s flash data success. Start from 0x%08X, size is %ld. The data is:\n",
rt_kprintf("Read the %s flash data success. Start from 0x%08lX, size is %ld. The data is:\n",
sfud_dev->name, addr, size);
rt_kprintf("Offset (h) 00 01 02 03 04 05 06 07 08 09 0A 0B 0C 0D 0E 0F\n");
for (i = 0; i < size; i += HEXDUMP_WIDTH)
{
rt_kprintf("[%08X] ", addr + i);
rt_kprintf("[%08lX] ", addr + i);
/* dump hex */
for (j = 0; j < HEXDUMP_WIDTH; j++) {
if (i + j < size) {
Expand Down Expand Up @@ -634,7 +634,7 @@ static void sf(uint8_t argc, char **argv) {
}
result = sfud_write(sfud_dev, addr, size, data);
if (result == SFUD_SUCCESS) {
rt_kprintf("Write the %s flash data success. Start from 0x%08X, size is %ld.\n",
rt_kprintf("Write the %s flash data success. Start from 0x%08lX, size is %ld.\n",
sfud_dev->name, addr, size);
rt_kprintf("Write data: ");
for (i = 0; i < size; i++) {
Expand All @@ -656,7 +656,7 @@ static void sf(uint8_t argc, char **argv) {
size = strtol(argv[3], NULL, 0);
result = sfud_erase(sfud_dev, addr, size);
if (result == SFUD_SUCCESS) {
rt_kprintf("Erase the %s flash data success. Start from 0x%08X, size is %ld.\n", sfud_dev->name,
rt_kprintf("Erase the %s flash data success. Start from 0x%08lX, size is %ld.\n", sfud_dev->name,
addr, size);
}
}
Expand Down Expand Up @@ -700,7 +700,7 @@ static void sf(uint8_t argc, char **argv) {
result = sfud_erase(sfud_dev, addr, size);
if (result == SFUD_SUCCESS) {
time_cast = rt_tick_get() - start_time;
rt_kprintf("Erase benchmark success, total time: %d.%03dS.\n", time_cast / RT_TICK_PER_SECOND,
rt_kprintf("Erase benchmark success, total time: %ld.%03ldS.\n", time_cast / RT_TICK_PER_SECOND,
time_cast % RT_TICK_PER_SECOND / ((RT_TICK_PER_SECOND * 1 + 999) / 1000));
} else {
rt_kprintf("Erase benchmark has an error. Error code: %d.\n", result);
Expand All @@ -716,13 +716,13 @@ static void sf(uint8_t argc, char **argv) {
}
result = sfud_write(sfud_dev, addr + i, cur_op_size, write_data);
if (result != SFUD_SUCCESS) {
rt_kprintf("Writing %s failed, already wr for %lu bytes, write %d each time\n", sfud_dev->name, i, write_size);
rt_kprintf("Writing %s failed, already wr for %u bytes, write %d each time\n", sfud_dev->name, i, write_size);
Copy link

Copilot AI Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug/错误: The loop variable i should use %lu format specifier instead of %u since it's likely a size_t or unsigned long type in the loop context. 循环变量 i 应该使用 %lu 格式说明符而不是 %u，因为它在循环上下文中可能是 size_t 或 unsigned long 类型。

Copilot uses AI. Check for mistakes.

break;
}
}
if (result == SFUD_SUCCESS) {
time_cast = rt_tick_get() - start_time;
rt_kprintf("Write benchmark success, total time: %d.%03dS.\n", time_cast / RT_TICK_PER_SECOND,
rt_kprintf("Write benchmark success, total time: %ld.%03ldS.\n", time_cast / RT_TICK_PER_SECOND,
time_cast % RT_TICK_PER_SECOND / ((RT_TICK_PER_SECOND * 1 + 999) / 1000));
} else {
rt_kprintf("Write benchmark has an error. Error code: %d.\n", result);
Expand All @@ -745,13 +745,13 @@ static void sf(uint8_t argc, char **argv) {
}

if (result != SFUD_SUCCESS) {
rt_kprintf("Read %s failed, already rd for %lu bytes, read %d each time\n", sfud_dev->name, i, read_size);
rt_kprintf("Read %s failed, already rd for %u bytes, read %d each time\n", sfud_dev->name, i, read_size);
Copy link

Copilot AI Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug/错误: The loop variable i should use %lu format specifier instead of %u since it's likely a size_t or unsigned long type in the loop context. 循环变量 i 应该使用 %lu 格式说明符而不是 %u，因为它在循环上下文中可能是 size_t 或 unsigned long 类型。

Suggested change
rt_kprintf("Read %s failed, already rd for %u bytes, read %d each time\n", sfud_dev->name, i, read_size);
rt_kprintf("Read %s failed, already rd for %lu bytes, read %d each time\n", sfud_dev->name, i, read_size);

Copilot uses AI. Check for mistakes.

break;
}
}
if (result == SFUD_SUCCESS) {
time_cast = rt_tick_get() - start_time;
rt_kprintf("Read benchmark success, total time: %d.%03dS.\n", time_cast / RT_TICK_PER_SECOND,
rt_kprintf("Read benchmark success, total time: %ld.%03ldS.\n", time_cast / RT_TICK_PER_SECOND,
time_cast % RT_TICK_PER_SECOND / ((RT_TICK_PER_SECOND * 1 + 999) / 1000));
} else {
rt_kprintf("Read benchmark has an error. Error code: %d.\n", result);
Expand Down
4 changes: 2 additions & 2 deletions components/finsh/msh_file.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,7 +796,7 @@ static int cmd_tail(int argc, char **argv)
}
}

rt_kprintf("\nTotal Number of lines:%d\n", total_lines);
rt_kprintf("\nTotal Number of lines:%ld\n", total_lines);

if (start_line != 0)
{
Expand All @@ -818,7 +818,7 @@ static int cmd_tail(int argc, char **argv)
close(fd);
return -1;
}
rt_kprintf("Required Number of lines:%d\n", required_lines);
rt_kprintf("Required Number of lines:%ld\n", required_lines);

target_line = total_lines - required_lines;
lseek(fd, 0, SEEK_SET); /* back to head */
Expand Down