Skip to content

utest: reorg menu #10821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 16, 2025
Merged

utest: reorg menu #10821

merged 3 commits into from
Oct 16, 2025

Conversation

@unicornx
Copy link
Contributor

@unicornx unicornx commented Oct 16, 2025 •
edited
Loading

最初的项目展示完全是平面的，现在它被组织成一个基于代码布局的树状层次结构。

mm 和 tmpfs 测试仍然保留，因为我们还没有处理（移动）这两个组件的源代码位置。

此外这个 pr 还改进菜单中显示的字符串，使用“Test” 代替“ Unit Testcases”以缩短字符串。使用大写字母使其看起来更醒目。

为方便 review，本 PR 分为三个 commit，merge时请不要压缩。最后一个 commit 是解决了PR #10808 “utest: unify configname” 中遗漏了的一个改动。

  • utest: reorg menu items
  • utest: Improve the strings displayed in the menu
  • utest: UTEST_MEMPOOL_TC -> RT_UTEST_MEMPOOL

修改前的 menu 效果：

image

修改后的 menu 效果：

第一级：
image
注：mm 和 tempfs 两个维持原样，因为这两块还没有处理完， 如果按照现在的设计，以后也会合并入 core 或者 components

第二级 Kernel Core
image

第二级 Kernel Components
image

@unicornx
utest: reorg menu items
57ae9a3 
The original project display was completely flat,
now it is organized into a tree-like hierarchical
structure based on the layout of the code.

mm & tmpfs test are still keep as pervious bcos we
have not move the source for these two components.

Signed-off-by: Chen Wang <[email protected]>
@github-actions
Copy link

github-actions bot commented Oct 16, 2025

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：dev-utest-reorg-menu
  • 设置PR number为 \ Set the PR number to：10821
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 dev-utest-reorg-menu 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the dev-utest-reorg-menu branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions
Copy link

github-actions bot commented Oct 16, 2025 •
edited
Loading

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: Maihuanyi

Changed Files (Click to expand)
  • components/dfs/utest/Kconfig
  • components/drivers/audio/utest/Kconfig
  • components/drivers/core/utest/Kconfig
  • components/drivers/ipc/utest/Kconfig
  • components/drivers/serial/utest/Kconfig
  • components/drivers/smp_call/utest/Kconfig
  • components/libc/cplusplus/utest/Kconfig
  • components/net/utest/Kconfig
  • components/utilities/utest/utest/Kconfig

🏷️ Tag: components_libc

Reviewers: GorrayLi mysterywolf

Changed Files (Click to expand)
  • components/libc/cplusplus/utest/Kconfig

🏷️ Tag: kernel

Reviewers: GorrayLi ReviewSun hamburger-os lianux-mm wdfk-prog xu18838022837

Changed Files (Click to expand)
  • src/klibc/utest/Kconfig
  • src/utest/Kconfig
  • src/utest/SConscript
  • src/utest/smp/Kconfig

📊 Current Review Status (Last Updated: 2025-10-16 15:00 CST)

  • ⌛ GorrayLi Pending Review
  • ⌛ Maihuanyi Pending Review
  • ⌛ ReviewSun Pending Review
  • ⌛ hamburger-os Pending Review
  • ⌛ lianux-mm Pending Review
  • ⌛ mysterywolf Pending Review
  • ⌛ wdfk-prog Pending Review
  • ⌛ xu18838022837 Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@unicornx unicornx removed the request for review from mysterywolf October 16, 2025 02:54
@Rbb666 Rbb666 added this to the v5.2.2 milestone Oct 16, 2025
@Rbb666 Rbb666 requested a review from Copilot October 16, 2025 06:29
Copilot AI reviewed Oct 16, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reorganizes the kernel unit test menu structure from a flat layout to a hierarchical tree structure based on code organization. The changes improve menu navigation by grouping related tests under logical categories (Kernel Core, Kernel Components/Drivers, etc.) and standardize menu text by using "Test" instead of "Unit Testcase" with proper capitalization for better readability.

Key changes:

  • Restructured Kconfig menu hierarchy to create multi-level organization
  • Standardized all menu and option text to use consistent "Test" nomenclature with title case
  • Renamed configuration option from UTEST_MEMPOOL_TC to RT_UTEST_MEMPOOL for consistency

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Kconfig.utestcases Reorganized top-level menu structure into "Kernel Core" and "Kernel Components" hierarchies
src/utest/Kconfig Updated menu title and standardized test option descriptions with title case
src/utest/smp/Kconfig Standardized SMP test descriptions with title case
src/utest/SConscript Updated config dependency from UTEST_MEMPOOL_TC to RT_UTEST_MEMPOOL
src/klibc/utest/Kconfig Simplified menu text to "Kernel Libc Test"
examples/utest/configs/kernel/mem.cfg Updated config reference to RT_UTEST_MEMPOOL
components/utilities/utest/utest/Kconfig Changed menu title to "Utest Framework"
components/net/utest/Kconfig Standardized network test menu and option titles
components/libc/cplusplus/utest/Kconfig Updated CPP11 menu and option titles
components/drivers/*/utest/Kconfig Standardized driver test menu titles across serial, ipc, core, audio, and smp_call
components/dfs/utest/Kconfig Updated filesystem test menu and option titles

components/drivers/serial/utest/Kconfig Outdated

config RT_SERIAL_TC_TXBUF_SIZE
int "the tx buffer size for serial test"
int "Tx Buffer Size for Serial Test"
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent capitalization: 'Tx' should be 'TX' to match 'RX' on line 20. / 大小写不一致：'Tx' 应改为 'TX' 以匹配第 20 行的 'RX'。

Suggested change
int "Tx Buffer Size for Serial Test"
int "TX Buffer Size for Serial Test"

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@unicornx unicornx Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks，I already fixed.

@unicornx
utest: Improve the strings displayed in the menu
ac517d8 
Use "Test" instead of "Unit Testcases" to make string shorter.
Use uppercase to make it look more eye-catching.

Signed-off-by: Chen Wang <[email protected]>
@unicornx
utest: UTEST_MEMPOOL_TC -> RT_UTEST_MEMPOOL
a4c4aa8 
Which is missed in PR RT-Thread#10808 "utest: unify configname", add it.

Signed-off-by: Chen Wang <[email protected]>
@unicornx unicornx force-pushed the dev-utest-reorg-menu branch from 01c2344 to a4c4aa8 Compare October 16, 2025 07:00
@unicornx
Copy link
Contributor Author

unicornx commented Oct 16, 2025

@Rbb666 我已经修改了 Copliot 的检查结果。但我有个问题，是不是我们没有权限请求 Copilot review code 以及修改后 re-request review from Copilot？

@Rbb666
Copy link
Member

Rbb666 commented Oct 16, 2025

@Rbb666 我已经修改了 Copliot 的检查结果。但我有个问题，是不是我们没有权限请求 Copilot review code 以及修改后 re-request review from Copilot？

我使用的是 Copilot Pro 版本，免费试用30天的，开通就有这个功能了😂

@Rbb666 Rbb666 merged commit 68a27e1 into RT-Thread:master Oct 16, 2025
57 checks passed
@unicornx unicornx mentioned this pull request Oct 20, 2025
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Rbb666 Rbb666 Rbb666 approved these changes

Assignees

No one assigned

Labels

component: drivers/audio component: drivers/core component: drivers/ipc component: drivers/serial component: drivers component: net Component Kernel PR has src relate code testcase

Projects

单元测试（UTEST）Framework
Status: Done

Milestone

v5.2.2

Development

Successfully merging this pull request may close these issues.

2 participants

@unicornx @Rbb666