Skip to content

Conversation

westcity-YOLO
Copy link

拉取/合并请求描述:(PR description)

[修复gd32f527的bsp中的adc适配问题。具体来说,修复了drv_adc.c文件中的API老旧以及不匹配问题。参考GD32F5xx系列的库文件,将老旧的API替换为新的API,并修正了宏定义配置。

为什么提交这份PR

在GD32F527的BSP中,ADC驱动的API与当前GD32F5xx系列的库文件不匹配,导致ADC无法正常工作。

你的解决方案是什么

参考GD32F5xx系列的库文件,更新了ADC驱动的API,使其与最新的库文件保持一致。同时,修正了相关的宏定义配置,并删除了不必要的代码。

请提供验证的bsp和config

  • BSP: bsp/gd32/arm/gd32527I-eval
  • .config: 使用默认配置,但使能了ADC驱动(如CONFIG_BSP_USING_ADC)
  • action: 由于是个人仓库的PR,暂时无法提供RT-Thread官方仓库的action链接。但已在本地成功编译并通过基本测试。

测试情况

已在GD32F527I-EVAL开发板上测试ADC功能,工作正常。
]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions github-actions bot added BSP BSP: GD32 BSP related with GD32 labels Oct 16, 2025
Copy link

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:test
  • 设置PR number为 \ Set the PR number to:10826
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 test 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the test branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2025

CLA assistant check
All committers have signed the CLA.

@westcity-YOLO westcity-YOLO changed the title 修复gd32f527配bsp drv_adc.c误适配适配adc宏定义即api的错误适配问题 RSOC-马锡尧-修复gd32f527的bs的adc驱动问题 Oct 16, 2025
@CYFS3
Copy link
Contributor

CYFS3 commented Oct 16, 2025

SOC_SERIES_GD32F5xx和SOC_SERIES_GD32F4xx系列的API应该是相同的,适配情况可以参考 #10737 ,然后主仓尽量保持最小化,adc就不要使能了。

# CONFIG_RT_USING_PHY is not set
# CONFIG_RT_USING_PHY_V2 is not set
# CONFIG_RT_USING_ADC is not set
CONFIG_RT_USING_ADC=y
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

默认建议不用开,如果需要验证,可以加.ciattachconfig 文件

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rbb666 Rbb666 added this to the v5.2.2 milestone Oct 20, 2025
@kurisaW kurisaW changed the title RSOC-马锡尧-修复gd32f527的bs的adc驱动问题 fix\rsoc: fix gd32f5xx adc driver problem Oct 20, 2025
@kurisaW
Copy link
Member

kurisaW commented Oct 20, 2025

image

验证一下gd32exx系列的定义是不是没考虑

@Rbb666 Rbb666 linked an issue Oct 21, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: GD32 BSP related with GD32 BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] 5.2.2 版本需合并PR汇总

6 participants