Skip to content

Conversation

@patowen
Copy link
Collaborator

@patowen patowen commented Jun 1, 2025

The term "depth" is arguably more intuitive when expressing how far away from the root a graph's node is, so this should hopefully reduce the barrier to entry for learning the Hypermine codebase.

As for "parent", previously, it was often interpreted as though every node (except the root) has one parent, even though most logic took all "shorter neighbors" into account, so "parent" now refers to any neighbor node closer to the root. The old meaning of parent is renamed to "primary parent", which is the parent with the first side in enum order.

Given that I hope to add the new terminology of "peer" nodes into the code base, I think it makes sense to rethink existing terms to make sure they're consistent with each other and with what one might expect. I would like to rename some of the terminology in dodeca as well, but I'm less sure about the right terminology, so I'll need to think on it some more and/or open an issue.

The term "depth" is arguably more intuitive when expressing how far away
from the root a graph's node is, so this should hopefully reduce the
barrier to entry for learning the Hypermine codebase.

As for "parent", previously, it was often interpreted as though every
node (except the root) has one parent, even though most logic took all
"shorter neighbors" into account, so "parent" now refers to any neighbor
node closer to the root. The old meaning of parent is renamed to
"primary parent", which is the parent with the first side in enum order.
@patowen patowen requested a review from Ralith June 1, 2025 22:25
Copy link
Owner

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if "shallower neighbor" would be a better term than "parent"? There's not really a hierarchy per se, after all.

@patowen
Copy link
Collaborator Author

patowen commented Jun 1, 2025

I wonder if "shallower neighbor" would be a better term than "parent"? There's not really a hierarchy per se, after all.

Definitely worth considering, although my current preference is still "parent". As for my reasoning: (1) It's shorter, making it less likely to result in long difficult-to-parse phrases when explaining certain logic, and (2) there is a hierarchy worth considering, as a node is not allowed to be added to the graph until all of its parents are added first.

@Ralith Ralith merged commit b6bfe22 into Ralith:master Jun 1, 2025
4 checks passed
@patowen patowen deleted the update-vocabulary branch June 1, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants