Adding some bass module tests #99
Open
+842
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaphaelIT7
reviewed
Oct 27, 2025
RaphaelIT7
requested changes
Oct 27, 2025
| expect( channel:GetState() ).to.equal( 1 ) | ||
| end) | ||
|
|
||
| done() |
There was a problem hiding this comment.
Please, in here do not use more timers & if you do, do not call done() before all of them finished, also I am like 99% sure these could have random behavior since the timers will all run the same tick.
| name = "Function is nil when module disabled", | ||
| when = not HolyLib_IsModuleEnabled( "bass" ), | ||
| func = function() | ||
| expect( bass.PlayFile ).to.beA( "nil" ) |
There was a problem hiding this comment.
This will error since the table bass will be nil, you can just do expect( bass )
| channel:Play() | ||
| expect( channel:GetState() ).to.equal( 1 ) | ||
|
|
||
| done() |
There was a problem hiding this comment.
Same as further below, please do not call done before its actually done, the timers still aren't done. Also please do not use timers at all unless they are nessesary.
| expect( channel:GetState() ).to.equal( 0 ) | ||
| end) | ||
|
|
||
| done() |
There was a problem hiding this comment.
Same again, please do not mark it as done & why the timer
RaphaelIT7
force-pushed
the
main
branch
4 times, most recently
from
3c6136a to
d279f42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes unit tests for some of the bass module methods
Bass
PlayFile()PlayUrl()IGModAudioChannel
__index()__newindex__tostring()Destroy()GetTable()Pause()Play()SetVolume()Stop()