Fix bug where sigma_r was incorrectly set to sigma_angles instead of sigma_distances. #133
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… incorrectly set to sigma_angles instead of sigma_distances.
|
Hello!! My apologies for not getting to this sooner (I've been unusually busy the past two weeks). Thanks for the effort, I'll take a look at this and merge it shortly!! |
|
A truly phenomenal bug catch🪲. One for the archives. Thanks. so much! |
|
Awesome. Thanks Tom! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the useful package!
When plotting BVC receptive fields I noticed that changing the sigma of the tuning distances does not change anything on the plots. It looks like this is because, within the plot_BVC_receptive_field() function in Neurons.py, sigma_r is being set to sigma_angles instead of sigma_distances, so changing the sigma_distances has no effect on the plots.