RcppArmadillo 14.6.3-1 with Armadillo 14.6.3#472
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates RcppArmadillo from version 14.6.2-1 to 14.6.3-1, upgrading the bundled Armadillo C++ library to version 14.6.3. The primary purpose is to fix OpenMP-related crashes in Cube::slice() on Arm64 CPUs by upgrading the minimum required OpenMP version from 3.1 to 4.0.
Key changes:
- Upgraded minimum OpenMP requirement from version 3.1 (201107) to 4.0 (201307)
- Added
seq_cstmemory order clause to atomic read/write operations for thread safety - Updated version numbers and documentation across all relevant files
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| inst/include/armadillo_bits/compiler_setup.hpp | Updated OpenMP version checks and warning messages to require 4.0+ |
| inst/include/armadillo_bits/arma_version.hpp | Incremented patch version from 2 to 3 |
| inst/include/armadillo_bits/arma_forward.hpp | Added seq_cst memory order to atomic operations |
| inst/include/armadillo_bits/Cube_meat.hpp | Added seq_cst memory order to atomic operations in Cube class |
| inst/NEWS.Rd | Added changelog entry for 14.6.3-1 release |
| configure.ac | Updated version string in autoconf configuration |
| configure | Updated generated configure script with new version |
| DESCRIPTION | Updated package version and date |
| ChangeLog | Added entry documenting the version update |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
|
Reverse-dependency checks reveal one regression with a package also failing at CRAN, see the run summary. |
|
The previously noted issue has been addressed by an upstream update in that package. |
No description provided.