Skip to content

Gitlab CI, patch tests for ancient R #7629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ben-schwen merged 3 commits into from
Jan 26, 2026
Merged

Gitlab CI, patch tests for ancient R #7629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e093c75
dont use lambdas in tests
ben-schwen Jan 26, 2026
3137cb8
supply origin for old (R 3.5.0) as.Date
ben-schwen Jan 26, 2026
8cf706e
remove comment
ben-schwen Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion inst/tests/nafill.Rraw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ test(15.22, nafill(x, fill=y26), replace(x, c(1L, 3L, 5L), y26))
test(15.23, nafill(x, fill=as.POSIXct(y26, tz='Asia/Singapore')), replace(x, c(1L, 3L, 5L), y26))

test(15.24, nafill(as.Date(NA), fill=as.IDate("2025-01-01")), as.Date("2025-01-01"))
test(15.25, nafill(as.Date(NA_integer_), fill=as.IDate("2025-01-01")), as.Date("2025-01-01"))
test(15.25, nafill(as.Date(NA_integer_, origin='1970-01-01'), fill=as.IDate("2025-01-01")), as.Date("2025-01-01"))
test(15.26, nafill(as.IDate(NA), fill=as.Date("2025-01-01")), as.IDate("2025-01-01"))

## setnafill
Expand Down
6 changes: 3 additions & 3 deletions inst/tests/tests.Rraw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21422,10 +21422,10 @@ test(2359.1, nchar(fread(txt)$foo), 409600L)
# rowwiseDT() valid and invalid handling of complex objects #7219
test(2360.1, rowwiseDT(x =, y =, 1, 2, 3, 4), data.table(x = c(1, 3), y = c(2, 4)))
test(2360.2, rowwiseDT(x =, func =,
1, list(\(x) x + 1),
1, list(function(x) x + 1),
2, list(function(z) z * 2)),
data.table(x = c(1, 2), func = list(\(x) x + 1, function(z) z * 2)))
test(2360.3, rowwiseDT(x =, func =, 1, \(x) x + 1),
data.table(x = c(1, 2), func = list(function(x) x + 1, function(z) z * 2)))
test(2360.3, rowwiseDT(x =, func =, 1, function(x) x + 1),
error = "Column 'func' is type 'function'. Non-atomic, non-list objects must be wrapped in list\\(\\)")
test(2360.4, rowwiseDT(x =, expr =, 1, quote(a + b)),
error = "Column 'expr' is type 'call'. Non-atomic, non-list objects must be wrapped in list\\(\\)")
Expand Down
Loading