Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the bids-validator Neurodocker template to support newer versions, specifically 2.x, by adapting the installation method. It introduces a conditional logic that allows older 1.x versions to continue using Node.js, while 2.x versions are now installed and run using Deno, streamlining the process for modern bids-validator releases. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the bids-validator template to support version 2.x, which uses Deno. The changes introduce a conditional installation path based on the major version. My review focuses on improving the robustness and correctness of the new installation script. I've identified a potential issue with the version detection logic that could fail for future releases, pointed out an unnecessary dependency, and suggested several improvements to the Deno installation script for better safety and correctness.
| if [ ! -z `which node` ] ; then \ | ||
| echo "node is installed, skipping its install." ; \ | ||
| else \ | ||
| {%- if self.version[0] == '1' %} \ |
There was a problem hiding this comment.
The version check self.version[0] == '1' is not robust. It will incorrectly handle major versions 10 and above (e.g., '10.0.0'). A more reliable approach is to parse the major version number and compare it as an integer.
{%- if self.version.split('.')[0] | int < 2 %} \| cp dist/validator/bids-validator.js /usr/bin/ | ||
| echo 'deno -A /usr/bin//bids-validator.js $@' > /usr/bin/bids-validator | ||
| chmod +x /usr/bin/bids-validator | ||
| rm -Rf $PWD |
There was a problem hiding this comment.
This part of the script can be improved for robustness and correctness:
- The path in the wrapper script contains a double slash (
//). This should be corrected to a single slash. - The
$@variable in the wrapper script should be quoted ("$@") to correctly handle arguments with spaces. - Using
rm -Rf $PWDis risky. A safer pattern is to change to the parent directory and then remove the build directory. - The
cpdestination can be made more explicit by including the filename.
cp dist/validator/bids-validator.js /usr/bin/bids-validator.js
echo 'deno -A /usr/bin/bids-validator.js "$@"' > /usr/bin/bids-validator
chmod +x /usr/bin/bids-validator
cd .. && rm -rf "bids-validator-{{ self.version }}"1 participant
Attempt at modifying the template of bids-validator for newer version using deno.
addresses #715