Add experimental trackCustomPaywallImpression API#1660
Open
Conversation
This was referenced Mar 10, 2026
github-merge-queue bot
pushed a commit
to RevenueCat/purchases-android
that referenced
this pull request
Mar 12, 2026
## Description Exposes `trackCustomPaywallImpression` as an experimental public API, allowing hybrid SDKs and consumers to track impressions of custom (non-RevenueCat) paywalls. ### Changes - New `CustomPaywallEventParams` class gated behind `@ExperimentalPreviewRevenueCatPurchasesAPI` - Public `trackCustomPaywallImpression` method on `Purchases` - API tester and Metalava API surface updates ### Related PRs - purchases-ios: RevenueCat/purchases-ios#6427 - purchases-hybrid-common: RevenueCat/purchases-hybrid-common#1537 - react-native-purchases: RevenueCat/react-native-purchases#1660 <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Introduces new public (experimental) API surface on `Purchases`, which can affect binary compatibility and downstream integrations if the signature or opt-in semantics change. > > **Overview** > Exposes `Purchases.trackCustomPaywallImpression` as an *experimental public API* (with overloads) to let apps track impressions for custom/non-RevenueCat paywalls, accepting optional `paywallId` via the new `CustomPaywallImpressionParams` type. > > Replaces the prior internal params type, updates API tester coverage (Java/Kotlin) to exercise the new calls, and refreshes Metalava API surface files and unit tests accordingly. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 3896706. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
rickvdl
added a commit
to RevenueCat/purchases-hybrid-common
that referenced
this pull request
Mar 12, 2026
## Description Adds bridge methods for `trackCustomPaywallImpression` on both iOS and Android, enabling hybrid SDKs to call the new experimental native API. ### Changes - iOS: `trackCustomPaywallImpression(_ data:)` in `CommonFunctionality.swift` - Android: `trackCustomPaywallImpression(data)` in `common.kt` Both methods accept a dictionary with an optional `paywallId` key and delegate to the native SDK. ### Related PRs - purchases-ios: RevenueCat/purchases-ios#6427 - purchases-android: RevenueCat/purchases-android#3199 - react-native-purchases: RevenueCat/react-native-purchases#1660
05efd6f to
6bafc79
Compare
This was referenced Mar 12, 2026
6bafc79 to
0d88f8e
Compare
ajpallares
approved these changes
Mar 13, 2026
Comment on lines
+631
to
+633
| if (@available(iOS 15.0, tvOS 15.0, macOS 12.0, watchOS 8.0, *)) { | ||
| [RCCommonFunctionality trackCustomPaywallImpression:data]; | ||
| } |
Contributor
There was a problem hiding this comment.
I remember we added isCustomPaywallTrackingAPIAvailable checker in PHC here
But it's true that the trackCustomPaywallImpression still requires iOS 15, etc.
I wonder how we could use the checker. At a minimum, we should probably log something if the method is not available
Member
Author
There was a problem hiding this comment.
Good pint, added the logging here as well :)
I don't think using isCustomPaywallTrackingAPIAvailable adds much value here since we have to do this @available check anyways. But please LMK if you disagree :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Exposes
trackCustomPaywallImpressionas a public API in React Native, enabling developers to track impressions of custom (non-RevenueCat) paywalls for analytics.The API is marked as experimental on the native side (
@_spi(Experimental)on iOS,@ExperimentalPreviewRevenueCatPurchasesAPIon Android) and documented with@experimentalJSDoc in TypeScript.Changes
RCT_EXPORT_METHOD(trackCustomPaywallImpression:)inRNPurchases.m@ReactMethod trackCustomPaywallImpressioninRNPurchasesModule.javaPurchases.trackCustomPaywallImpression()inpurchases.tsRelated PRs