changed from '.uavcan' to '.dsdl' in DsdlParser#39
Merged
Conversation
TheLarsinator
requested changes
Feb 5, 2025
updated from v2 -> v3: - uses: actions/checkout@v3 - uses: actions/upload-artifact@v3 - uses: actions/upload-artifact@v3
Turns out v3 is also depreciated https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ Trying v4 here.
Contributor
|
Have you tested it in Analyze with the new dsdl branch and some live data stream? Ask some of the electrical guys, or just replay some old data. |
Contributor
|
Nice that you updated the dependency! @jkguttormsen I think they can merge even without testing and then create a new issue/ticket for testing, even if it doesn't work right away it likely is not to be dealt with in this repo anyhow and it won't hurt past logs |
AliceMadama
approved these changes
Feb 8, 2025
TheLarsinator
approved these changes
Feb 8, 2025
jkguttormsen
approved these changes
Feb 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yolo merge requested right here