Skip to content

Remove unix.rs#5

Open
Calder White (cwhite-rippling) wants to merge 3 commits intomainfrom
calder/remove-unix
Open

Remove unix.rs#5
Calder White (cwhite-rippling) wants to merge 3 commits intomainfrom
calder/remove-unix

Conversation

@cwhite-rippling
Copy link
Copy Markdown
Contributor

Removing unix.rs. I think it got leaked in based on the way I moved this out of the internal Rippling codebase.

We do not support unix, only macOS and Windows.

Copy link
Copy Markdown
Collaborator

@adarshr10 Adarsh Rao (adarshr10) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the readme to reflect this - I think right now it says the implementation is for all platforms

@brhoades
Copy link
Copy Markdown

Billy Rhoades (brhoades) commented Jul 24, 2024

We do not support unix, only macOS and Windows.

But should we? I seem to remember that both MacOS and Unix impls would run through libc APIs.

@cwhite-rippling
Copy link
Copy Markdown
Contributor Author

Billy Rhoades (@brhoades) I am open to supporting unix. When this was internal we had agreed to only support macOS and Windows. I will have to check the unix syscall to make sure it doesn't introduce any new edge cases. My intuition is that the edge cases observed on macOS will be a superset of the edge cases on unix, so this could be a quick win.

@cwhite-rippling
Copy link
Copy Markdown
Contributor Author

If we do end up supporting unix, I think I will also introduce a changelog to suspend-time, with v0.1.2 having one of its changes be "add unix support". I think this will be good for tracking when things were introduced in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants