Conversation
Adarsh Rao (adarshr10)
left a comment
There was a problem hiding this comment.
We should update the readme to reflect this - I think right now it says the implementation is for all platforms
But should we? I seem to remember that both MacOS and Unix impls would run through libc APIs. |
|
Billy Rhoades (@brhoades) I am open to supporting unix. When this was internal we had agreed to only support macOS and Windows. I will have to check the unix syscall to make sure it doesn't introduce any new edge cases. My intuition is that the edge cases observed on macOS will be a superset of the edge cases on unix, so this could be a quick win. |
|
If we do end up supporting unix, I think I will also introduce a changelog to suspend-time, with v0.1.2 having one of its changes be "add unix support". I think this will be good for tracking when things were introduced in the future. |
Removing unix.rs. I think it got leaked in based on the way I moved this out of the internal Rippling codebase.
We do not support unix, only macOS and Windows.