[tools] Remove bzlcodestyle (#23520)

It is not a good value. Buildifier is sufficient on its own.

Author: jwnimmer-tri

doc/_pages/code_style_tools.md

@@ -40,8 +40,8 @@ User manuals for the style-checking tools are as follows:
     [http://pycodestyle.readthedocs.io/en/latest/intro.html](http://pycodestyle.readthedocs.io/en/latest/intro.html).
   * The syntax ``# noqa`` can be used to quiet the warning about an overly-long
     line.
-* Bazel: Uses both pycodestyle like Python, and also the buildifier tool as
-  described in [Updating BUILD files](/bazel.html#updating-build-files).
+* Bazel: Uses the buildifier tool as described in
+  [Updating BUILD files](/bazel.html#updating-build-files).
 
 To opt-out of all linting (e.g., when committing vendored copies of third-party
 external files into Drake's workspace), add `tags = ["nolint"]` to the

tools/lint/BUILD.bazel

@@ -82,16 +82,6 @@ drake_py_binary(
     ],
 )
 
-drake_py_binary(
-    name = "bzlcodestyle",
-    srcs = ["bzlcodestyle.py"],
-    main = "bzlcodestyle.py",
-    deps = [
-        ":module_py",
-        "@pycodestyle_internal//:pycodestyle",
-    ],
-)
-
 drake_py_binary(
     name = "install_lint_reporter",
     testonly = 1,

tools/lint/bazel_lint.bzl

@@ -3,27 +3,10 @@ load("//tools/skylark:drake_py.bzl", "py_test_isolated")
 #------------------------------------------------------------------------------
 # Internal helper; set up test given name and list of files. Will do nothing
 # if no files given.
-def _bazel_lint(name, files, ignore):
+def _bazel_lint(name, files):
     if files:
-        ignores = ["E%s" % e for e in (ignore or [])]
-
-        # W504 relates to linebreaks around binary operators; buildifier
-        # disagrees with what pycodestyle wants to do.
-        ignores.append("W504")
-
-        ignores_as_arg = ["--ignore=" + ",".join(ignores)]
         locations = ["$(locations %s)" % f for f in files]
 
-        py_test_isolated(
-            name = name + "_codestyle",
-            size = "small",
-            srcs = ["@drake//tools/lint:bzlcodestyle"],
-            data = files,
-            args = ignores_as_arg + locations + ["--max-line-length=80"],
-            main = "@drake//tools/lint:bzlcodestyle.py",
-            tags = ["bzlcodestyle", "lint"],
-        )
-
         py_test_isolated(
             name = name + "_buildifier",
             size = "small",
@@ -37,32 +20,20 @@ def _bazel_lint(name, files, ignore):
 #------------------------------------------------------------------------------
 def bazel_lint(
         name = "bazel",
-        ignore = None,
         extra_srcs = None,
         exclude = None):
     """
-    Runs the ``bzlcodestyle`` code style checker on all Bazel files in the
-    current directory. The tool is based on the ``pycodestyle`` :pep:`8` code
-    style checker, but always disables certain checks while adding others.
+    Runs ``buildifier -mode=check`` format checker on all Bazel files in the
+    current directory.
 
     Args:
         name: Name prefix of the test (default = "bazel").
-        ignore: List of errors (as integers, without the 'E') to ignore
-            (default = [265, 302, 305]).
         extra_srcs: List of files to lint that would otherwise be missed by the
             default glob pattern for Bazel source code.
         exclude: List to be passed to the skylark glob function for files that
             should not be linted (e.g., vendored files).
-
-    Example:
-        BUILD:
-            load("//tools/lint:bazel_lint.bzl", "bazel_lint")
-
-            bazel_lint()
     """
 
-    if ignore == None:
-        ignore = [265, 302, 305]
     if extra_srcs == None:
         extra_srcs = []
     if exclude == None:
@@ -82,5 +53,4 @@ def bazel_lint(
             exclude = exclude,
             allow_empty = True,
         ) + extra_srcs,
-        ignore = ignore,
     )

tools/lint/bzlcodestyle.py

@@ -10,7 +10,6 @@ def add_lint_tests(
         python_lint_exclude = None,
         python_lint_extra_srcs = None,
         python_lint_use_ruff = False,
-        bazel_lint_ignore = None,
         bazel_lint_extra_srcs = None,
         bazel_lint_exclude = None,
         enable_install_lint = True,
@@ -39,7 +38,6 @@ def add_lint_tests(
         use_ruff = python_lint_use_ruff,
     )
     bazel_lint(
-        ignore = bazel_lint_ignore,
         extra_srcs = bazel_lint_extra_srcs,
         exclude = bazel_lint_exclude,
     )