Open
Conversation
added Root Mean Squared error function.
Collaborator
|
@omkarcharatkar while the code LGTM, it seems that there are issues with lint in your PR. Please look at the automated tests for this PR and check for the lint errors. We use PEP8 guidelines very strictly like most other python repositories and use flake8 to check for lint errors. You can run such checks yourself by installing flake8 and running it in your python code repository.
In the code repository run - |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added Root Mean Squared error function.
References to other Issues or PRs or Relevant literature
Brief description of what is fixed or changed
Other comments