-
-
Notifications
You must be signed in to change notification settings - Fork 200
mnt/extract flight data exporters #845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
mnt/extract flight data exporters #845
Conversation
I really like what I see here... I will take a look at it asap |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #845 +/- ##
===========================================
+ Coverage 80.02% 80.12% +0.09%
===========================================
Files 98 104 +6
Lines 12004 12552 +548
===========================================
+ Hits 9606 10057 +451
- Misses 2398 2495 +97 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sounds good, let me know if there's anything that needs to be done or revised before this can be merged to develop...I have some enhancements of the kml export I have in the works and I'd rather not stack the PR branches and have to deal with rebasing later if we can help it :) |
@Gui-FernandesBR Sorry if this PR disappeared for a few days...my account got false flagged by the GitHub bots |
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest tests -m slow --runslow
) have passed locallyCHANGELOG.md
has been updated (if relevant)Current behavior
Export routines for
Flight
live as instance methods inrocketpy/simulation/flight.py
(export_data
,export_pressures
,export_sensor_data
,export_kml
). This mixes simulation with I/O concerns and forces an import-time dependency onsimplekml
for users who do not export.New behavior
FlightDataExporter
atrocketpy/simulation/flight_data_exporter.py
.Flight
methods that delegate toFlightDataExporter
and emitDeprecationWarning
with migration guidance.FlightDataExporter
inrocketpy/simulation/__init__.py
.v1.12.0
.Breaking change
Additional information
Moved to FlightDataExporter.export_data() and will be removed in v1.12.0.
MPLBACKEND=Agg
.