chore: remove diffEnabled and fuzzyMatchThreshold settings #10298
+26
−536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
Contributor
Re-review complete. All previously flagged issues have been resolved. No new issues found.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
hannesrudolph
added
PR - Draft / In Progress
and removed
Issue/PR - Triage
hannesrudolph
force-pushed
the
chore/remove-diff-enabled-setting
branch
from
2c6ed92 to
4ab09f1
Compare
Native tool calling makes these controls obsolete. Removes: - diffEnabled and fuzzyMatchThreshold from provider settings types - DiffSettingsControl UI component - Related translations from all 18 locale files - System prompt diffEnabled parameter - Conditional apply_diff tool filtering based on diffEnabled - Associated tests and migrations
Remove enableDiff property from public CreateTaskOptions interface since diffs are now always enabled. This addresses the review feedback to clean up the no-op property. - Remove enableDiff from packages/types/src/task.ts - Remove enableDiff usage from test file
hannesrudolph
force-pushed
the
chore/remove-diff-enabled-setting
branch
from
fb5481b to
8a75e60
Compare
mrubens
approved these changes
Jan 23, 2026
github-project-automation
bot
moved this from PR [Draft / In Progress]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10648
Summary
Removes the
diffEnabledtoggle andfuzzyMatchThresholdslider settings from Roo Code. These settings are being removed for several reasons:Fuzzy matching was a band-aid - It was introduced for weaker models that couldn't produce exact matches, but 100% precision is the correct approach. Fuzzy matching just papers over model quality issues while introducing risk of incorrect replacements.
Settings were misleading - These settings appeared in the UI for all configurations, including OpenAI-native models that use
apply_patchinstead ofapply_diff. Users could toggle these settings thinking they were affecting behavior when in reality they had zero impact.False sense of control - If diffs aren't working, tweaking fuzzy match thresholds doesn't fix the root cause. These settings gave users knobs that don't solve their actual problems.
OOTB complexity - These settings added cognitive load without meaningful benefit, overcomplicating the out-of-box experience.
Changes
diffEnabledandfuzzyMatchThresholdfrom provider settings types (provider-settings.ts,global-settings.ts,task.ts,cloud.ts)DiffSettingsControl.tsxUI component entirelydiffEnabledparameter fromSYSTEM_PROMPT()function signatureapply_difftool exclusion fromfilter-tools-for-mode.tsdiffEnabledmigration fromProviderSettingsManager.tssetDiffEnabledandsetFuzzyMatchThresholdfromExtensionStateContext.tsxmatchPrecisiontranslations from all 18 locale files