Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Jan 22, 2026

Fixed false validation error when using local Ollama models. The validation logic was checking against an empty router models object placeholder, causing incorrect errors even when models existed locally.

Now only validates against router models if they actually contain data.

Fixes ROO-581


View task on Roo Code Cloud


Important

Fixes false validation error in Ollama.tsx by ensuring validation only occurs if router models contain data.

  • Behavior:
    • Fixes false validation error in Ollama.tsx by checking if routerModels.data.ollama contains data before validating.
    • Ensures local models are not incorrectly flagged as unavailable.
  • Validation Logic:
    • Updates condition in useMemo to validate against routerModels only if it has data.
    • Removes unnecessary validation against empty router models.

This description was created by Ellipsis for 918bc1e. You can customize this summary. It will automatically update as commits are pushed.

The validation logic was checking against an empty router models object
that was initialized but never populated for Ollama. This caused false
validation errors even when models existed locally.

Now only validates against router models if they actually contain data,
preventing the false error when using local Ollama models.

Fixes ROO-581
@roomote
Copy link
Contributor Author

roomote bot commented Jan 22, 2026

Rooviewer Clock   See task on Roo Cloud

No issues found. The fix correctly addresses the false validation error by ensuring router models are only validated when they actually contain data.

  • Review complete - no issues to resolve

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@brunobergher brunobergher marked this pull request as ready for review January 22, 2026 10:30
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Jan 22, 2026
@roomote
Copy link
Contributor Author

roomote bot commented Jan 22, 2026

Rooviewer Clock   See task on Roo Cloud

No issues found. The fix correctly addresses the false validation error by ensuring router models are only validated when they actually contain data.

  • Review complete - no issues to resolve

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

3 participants