Support chain designations of multiple letters.#551
Open
roccomoretti wants to merge 18 commits intoRosettaCommons:mainfrom
Open
Support chain designations of multiple letters.#551roccomoretti wants to merge 18 commits intoRosettaCommons:mainfrom
roccomoretti wants to merge 18 commits intoRosettaCommons:mainfrom
Conversation
roccomoretti
added
ready_for_review
lyskov
approved these changes
Oct 28, 2025
Member
lyskov
left a comment
lyskov
left a comment
There was a problem hiding this comment.
Tentatively approving, pending successful test runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the "better support for mmCIF format" effort.
The mmCIF format supports larger systems with multi-character chain designations. This PR changes the internals of Rosetta to support multi-letter chain designations. There shouldn't be any significant behavioral changes if you just continue to use single letter chain designations.
The most significant interface change was the change in interface designation. Instead of strings like "A_B", code now generally takes a
core::pose::DockingPartnersobject. (This can be created from the string designation, to ease IO - it should be invisible except perhaps at the PyRosetta level.)Places that needed to be fixed were discovered primarily with type change issues during compilation. I may have missed some places which need updated support.
Apologies for the massive size of this PR, it would be hard to make such a fundamental change in any smaller unit.