Fixes to the Optix crate #157
Conversation
|
Note you are going to want to rebase on #156 as it touches a ton of stuff. |
|
(it's just about ready to land) |
|
Gotcha, will do! Thanks for letting me know. I'll keep this open and rebase on top once that drops, if that works |
Schmiedium
force-pushed
the
fix_optix_compile_errors
branch
from
5dfb476 to
7e7007d
Compare
|
Rebased on top of the recent changes from #156, checked that everything still works |
LegNeato
left a comment
LegNeato
left a comment
There was a problem hiding this comment.
I think the MotionFlags doc comments need to be moved out of the impl and on the struct like BuildFlags has them?
It would be nice to have all of these documented in general but keeping the staus quo is all that is required. Thanks for the PR!
|
Understood, I can reorganize that and push up the changes shortly. I can work on documenting the rest of them as well, that might take a minute as I figure out the specifics of what they do. Thanks for reviewing! |
…stead of the impl block
|
looks like this overlaps with #159 |
|
Okay, should I close this one out then? I'd prefer not to duplicate work in the future |
|
Yeah, it looks like that one landed already and had the changes you were planning to do. Sorry! I very much appreciate your PRs ❤️. People work on what they want to work on, and looks like you had a bit of some bad luck with others overlapping. Sorry for the bad contributing experience, I will try to make it better! |
|
No worries! I appreciate the feedback. This is my first time contributing to open source, so I'm trying to make sure I do things the right way and learn as much as I can is all haha. These things happen, I'm mostly just happy this project is making headway Thank you for the kind words, I appreciate it |
3 participants
Some new traits needed to be derived for MotionFlags, InstanceFlags, and some others. Additonally, from here: https://docs.rs/bitflags/latest/bitflags/, it looks we need to use the impl syntax for the bit flag structs to work with the custom derive macros from cust.
Also fixed a warning about an elided lifetime