x509-cert: re-export spki types without *Owned suffixes
#1534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-exports the following with shorter names: - `spki::AlgorithmIdentifierOwned` => `x509_cert::AlgorithmIdentifier` - `spki::SubjectPublicKeyInfoOwned` => `x509_cert::SubjectPublicKeyInfo` These names are already quite long to begin with even without the `*Owned` suffix. The `x509-cert` crate has a hard dependency on `alloc` and always uses the `*Owned` types, so this allows for more convenient names in this scenario.
Member
Author
|
Thought shorter names would be nice, but it does risk being a bit confusing in regard to |
baloo
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-exports the following with shorter names:
spki::AlgorithmIdentifierOwned=>x509_cert::AlgorithmIdentifierspki::SubjectPublicKeyInfoOwned=>x509_cert::SubjectPublicKeyInfoThese names are already quite long to begin with even without the
*Ownedsuffix.The
x509-certcrate has a hard dependency onallocand always uses the*Ownedtypes, so this allows for more convenient names in this scenario.