Skip to content

Conversation

tarcieri
Copy link
Member

@tarcieri tarcieri commented Sep 2, 2025

Currently getting a test failure(!) in dsa, possibly related to crypto-bigint changes?

---- verify_signature stdout ----

thread 'verify_signature' panicked at dsa/tests/signature.rs:91:5:
assertion failed: verifying_key.verify_digest(Sha256::new().chain_update(MESSAGE),
        &signature).is_ok()
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- sign_message stdout ----

thread 'sign_message' panicked at dsa/tests/signature.rs:80:5:
assertion `left == right` failed
  left: Signature { r: NonZero(BoxedUint(0x00000000C6639F3AC90E4AAE648FB30C885F96A0C5E32D09)), s: NonZero(BoxedUint(0x00000000BFF0252CE80AC9281C12395433CA2FEC8A0DAAFF)) }
 right: Signature { r: NonZero(BoxedUint(0x000000004E12277518F640E33ADB806DE798D3A340F59D0F)), s: NonZero(BoxedUint(0x0000000017781EC8535891E03F2D3627366BAC8ED7F9A4CF)) }

Edit: confirm this test failure appears when updating crypto-bigint alone, going to bisect the changes.

Edit again: bisected to RustCrypto/crypto-bigint#920

tarcieri added a commit to RustCrypto/crypto-bigint that referenced this pull request Sep 2, 2025
This reverts commit 4c891c2.

The `dsa` crate's tests in RustCrypto/signatures#1047 were failing and I
bisected the failures to this commit.
tarcieri added a commit to RustCrypto/crypto-bigint that referenced this pull request Sep 2, 2025
This reverts commit 4c891c2.

The `dsa` crate's tests in RustCrypto/signatures#1047 were failing and I
bisected the failures to this commit.

I have confirmed the `dsa` crate tests pass with this reverted.

cc @andrewwhitehead
@tarcieri tarcieri marked this pull request as ready for review September 2, 2025 02:08
@tarcieri tarcieri changed the title [WIP] Bump hybrid-array to v0.4 Bump hybrid-array to v0.4 Sep 2, 2025
@tarcieri tarcieri merged commit 137ec79 into master Sep 2, 2025
76 checks passed
@tarcieri tarcieri deleted the hybrid-array/v0.4 branch September 2, 2025 02:24
zhifenxing071346lorrainewyatt added a commit to zhifenxing071346lorrainewyatt/crypto-bigint that referenced this pull request Oct 4, 2025
This reverts commit 4c891c200c309646b54f7e36572422d4dc91e129.

The `dsa` crate's tests in RustCrypto/signatures#1047 were failing and I
bisected the failures to this commit.

I have confirmed the `dsa` crate tests pass with this reverted.

cc @andrewwhitehead
charlizemorgenbriancox added a commit to charlizemorgenbriancox/crypto-bigint that referenced this pull request Oct 10, 2025
This reverts commit 4c891c200c309646b54f7e36572422d4dc91e129.

The `dsa` crate's tests in RustCrypto/signatures#1047 were failing and I
bisected the failures to this commit.

I have confirmed the `dsa` crate tests pass with this reverted.

cc @andrewwhitehead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant