chore: apply unreachable_pub lint
#1062
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
commented
Sep 16, 2025
| pub(crate) type Pow2DMinus1Minus1 = Diff<Pow2DMinus1, U1>; | ||
|
|
||
| /// An integer that describes a bit length to be used in sampling | ||
| #[expect(unreachable_pub)] |
There was a problem hiding this comment.
There's a couple of instances of unreachable pub traits which need to remain pub due to trait constraints on associated types in pub traits. I've silenced the warning without making these reachable in these cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues on with updates started in RustCrypto/hashes#734. Still needs a couple of crates to be dealt with.