rfc6979: replace Digest requirement with EagerHash
#1076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
reviewed
Sep 15, 2025
daxpedda
force-pushed
the
signature-digest-remove-digest
branch
2 times, most recently
from
9765151 to
f0ccd6c
Compare
daxpedda
commented
Sep 15, 2025
daxpedda
force-pushed
the
signature-digest-remove-digest
branch
3 times, most recently
from
50564db to
40b250b
Compare
daxpedda
force-pushed
the
signature-digest-remove-digest
branch
from
40b250b to
4f9a6fe
Compare
tarcieri
reviewed
Sep 15, 2025
Comment on lines
+43
to
+44
| arithmetic = ["dep:hmac", "dep:rfc6979", "elliptic-curve/arithmetic"] | ||
| algorithm = ["dep:rfc6979", "arithmetic", "digest", "hazmat"] |
There was a problem hiding this comment.
Hmm, maybe these could be consolidated?
There was a problem hiding this comment.
Do you want me to do this here or in a follow-up?
tarcieri
approved these changes
Sep 15, 2025
tarcieri
added a commit
to RustCrypto/traits
that referenced
this pull request
Sep 15, 2025
Originally added in RustCrypto/MACs#151 The situation is `ecdsa` has a trait for the "default" hash function to use for a particular curve, which we want to work with RFC6979 and ergo HMAC, so we would like to use an `EagerHash` bound. But `rfc6979` is an optional dependency, so we can't depend on its transitive accessibility to `rfc6979::hmac`. This PR added `hmac` as a dependency gated on the `digest` feature of `ecdsa`: RustCrypto/signatures#1076 But as I was looking at `EagerHash` I noticed there's nothing HMAC-specific about it at all and it can easily be moved to `digest`, so we're able to use it in bounds without any other dependencies besides `digest`, which would be nice.
newpavlov
pushed a commit
to RustCrypto/traits
that referenced
this pull request
Sep 16, 2025
Originally added in RustCrypto/MACs#151 The situation is `ecdsa` has a trait for the "default" hash function to use for a particular curve, which we want to work with RFC6979 and ergo HMAC, so we would like to use an `EagerHash` bound. But `rfc6979` is an optional dependency, so we can't depend on its transitive accessibility to `rfc6979::hmac`. This PR added `hmac` as a dependency gated on the `digest` feature of `ecdsa`: RustCrypto/signatures#1076 But as I was looking at `EagerHash` I noticed there's nothing HMAC-specific about it at all and it can easily be moved to `digest`, so we're able to use it in bounds without any other dependencies besides `digest`, which would be nice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the
Digestrequirements ofrfc6979items withEagerHash. In the process I merged theecdsasigningandverifyingcrate features intosignature.As discussed in RustCrypto/elliptic-curves#1423 (comment).