Skip to content

Prevent DOS due large SAML Message. Fixes CVE-2025-54572 #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025
Merged

Prevent DOS due large SAML Message. Fixes CVE-2025-54572 #770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/ruby_saml/xml/decoder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@ module Decoder
# to prevent a possible DoS attack.
# @return [String] The plain SAML Message
def decode_message(message, max_bytesize = nil)
return message unless base64_encoded?(message)

max_bytesize ||= DEFAULT_MAX_BYTESIZE

if message.bytesize > max_bytesize # rubocop:disable Style/IfUnlessModifier
raise ValidationError.new("Encoded SAML Message exceeds #{max_bytesize} bytes, so was rejected")
end

return message unless base64_encoded?(message)

message = try_inflate(base64_decode(message))

if message.bytesize > max_bytesize # rubocop:disable Style/IfUnlessModifier
Expand Down
Loading