Tree Tables: Modifications #843
Conversation
Fiori: Tree View Object Page
| annotate sap.capire.bookshop.Genres with @fiori.draft.enabled; | ||
| annotate AdminService.Genres with @odata.draft.enabled; | ||
| annotate AdminService.Genres with @odata.draft.bypass; |
There was a problem hiding this comment.
Why do we need that here, in admin-books, at all?
And why all three?
| entity Books as projection on my.Books; | ||
| entity Genres as projection on my.Genres; | ||
| entity Contents as projection on my.Contents; |
There was a problem hiding this comment.
Why do we need to expose that explicitly?
Composition targets are auto-exposed, as part of their roots. Only root entities should be exposed explicitly.
| /** Hierarchically organized entity for Contents */ | ||
| entity Contents { | ||
| key ID : UUID; | ||
| name : String; | ||
| page : Integer; | ||
| parent : Association to Contents; | ||
| children : Composition of many Contents on children.parent = $self; | ||
| book : Association to Books; | ||
| } | ||
|
|
There was a problem hiding this comment.
We should not pollute our central getting-started sample, but move that to the fiori / bookstore project.
| price : Price; | ||
| currency : Currency; | ||
| image : LargeBinary @Core.MediaType: 'image/png'; | ||
| contents : Composition of many Contents on contents.book = $self; |
There was a problem hiding this comment.
We should not pollute our central getting-started sample, but move that to the fiori / bookstore project.
| @@ -0,0 +1,64 @@ | |||
| ID;parent_ID;name;page;book_ID | |||
There was a problem hiding this comment.
We should not pollute our central getting-started sample, but move that to the fiori / bookstore project.
| /** For displaying lists of Books */ | ||
| @readonly entity ListOfBooks as projection on Books | ||
| excluding { descr }; | ||
| excluding { descr, contents }; |
There was a problem hiding this comment.
Revert when we move Contents to bookstore
| @readonly entity Books as projection on my.Books { *, | ||
| author.name as author | ||
| } excluding { createdBy, modifiedBy }; | ||
| } excluding { createdBy, modifiedBy, contents }; |
There was a problem hiding this comment.
Revert when we move Contents to bookstore
| action submitOrder ( book: Books:ID, quantity: Integer ) returns { stock: Integer }; | ||
| event OrderedBook : { book: Books:ID; quantity: Integer; buyer: String }; | ||
| } | ||
| } |
There was a problem hiding this comment.
Keep empty lines at the end of files
| {$Type: 'UI.ReferenceFacet', Label: '{i18n>Details}', Target: '@UI.FieldGroup#Details'}, | ||
| {$Type: 'UI.ReferenceFacet', Label: '{i18n>Admin}', Target: '@UI.FieldGroup#Admin'}, | ||
| {$Type: 'UI.ReferenceFacet', Label: '{i18n>General}', Target: '@UI.FieldGroup#General'}, | ||
| {$Type: 'UI.ReferenceFacet', Label: '{i18n>Translations}', Target: 'texts/@UI.LineItem'}, |
There was a problem hiding this comment.
Please stick to consistent 2-spaces indent in samples
| texts.locale, | ||
| } excluding { contents }; |
There was a problem hiding this comment.
Revert when we moved Contents to fiori / bookstore
3 participants
No description provided.