Transparent proxy: TP Loader Cloud SDK native integration #981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
VladislavAtanasov95
force-pushed
the
tploader
branch
7 times, most recently
from
b860033 to
cb21b31
Compare
...rvice/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxyLoader.java
Outdated
Show resolved
Hide resolved
...rvice/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxyLoader.java
Outdated
Show resolved
Hide resolved
...rvice/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxyLoader.java
Outdated
Show resolved
Hide resolved
KNikovv
reviewed
Oct 23, 2025
...rvice/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxyLoader.java
Outdated
Show resolved
Hide resolved
...rvice/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxyLoader.java
Outdated
Show resolved
Hide resolved
...rvice/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxyLoader.java
Outdated
Show resolved
Hide resolved
...rvice/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxyLoader.java
Outdated
Show resolved
Hide resolved
...rvice/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxyLoader.java
Outdated
Show resolved
Hide resolved
Comment on lines
79
to
88
| void testRegisterWithHostWithHttpsScheme() | ||
| { | ||
| // Test that existing https:// scheme is preserved | ||
| TransparentProxyLoader.register("https://gateway"); | ||
|
|
||
| Try<Destination> result = loader.tryGetDestination("test-destination"); | ||
| assertThat(result.isSuccess()).isTrue(); | ||
|
|
||
| Destination destination = result.get(); | ||
| assertThat(destination.asHttp().getUri().toString()).startsWith("https://gateway"); | ||
| } |
There was a problem hiding this comment.
the destination gateway can't be called via https
Author
There was a problem hiding this comment.
discussed to allow it for now
VladislavAtanasov95
force-pushed
the
tploader
branch
11 times, most recently
from
bc1d50c to
f7ee4bd
Compare
Author
|
@MatKuhr please review |
VladislavAtanasov95
force-pushed
the
tploader
branch
2 times, most recently
from
72dc4c1 to
70ee9ae
Compare
| * </ul> | ||
| */ | ||
| @Override | ||
| public void verifyHostConnectivity( @Nonnull final String host, final int port ) |
There was a problem hiding this comment.
do we need this publicly accessible?
Author
There was a problem hiding this comment.
made NetworkValidator abstract class to make this method package-private
VladislavAtanasov95
force-pushed
the
tploader
branch
from
70ee9ae to
18db618
Compare
VladislavAtanasov95
force-pushed
the
tploader
branch
from
18db618 to
de06843
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.