Skip to content

Conversation

tobiasqueck
Copy link
Contributor

@tobiasqueck tobiasqueck commented Jun 14, 2024

  • enhance system-access with refreshToken handling as it is in the backend-proxy-middleware
  • replace backend-proxy-middleware code that accesses a system with system-access
  • enhance and refactor the unit tests

Copy link

changeset-bot bot commented Jun 14, 2024

🦋 Changeset detected

Latest commit: 24c48c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@sap-ux/backend-proxy-middleware Patch
@sap-ux/axios-extension Patch
@sap-ux/system-access Patch
@sap-ux/abap-deploy-config-inquirer Patch
@sap-ux/adp-flp-config-sub-generator Patch
@sap-ux/adp-tooling Patch
@sap-ux/app-config-writer Patch
@sap-ux/deploy-tooling Patch
@sap-ux/environment-check Patch
@sap-ux/fiori-app-sub-generator Patch
@sap-ux/flp-config-inquirer Patch
@sap-ux/generator-adp Patch
@sap-ux/odata-service-inquirer Patch
@sap-ux/preview-middleware Patch
@sap-ux/repo-app-import-sub-generator Patch
@sap-ux/ui-service-inquirer Patch
@sap-ux/ui-service-sub-generator Patch
@sap-ux/odata-cli Patch
@sap-ux/generator-simple-fe Patch
@sap-ux/abap-deploy-config-sub-generator Patch
@sap-ux/abap-deploy-config-writer Patch
@sap-ux/create Patch
@sap-ux/deploy-config-sub-generator Patch
@sap-ux/flp-config-sub-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
72.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Aug 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
69.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@heimwege
Copy link
Contributor

@tobiasqueck do you want to follow-up on this one? Still seems like a reasonable adjustment to me.

@tobiasqueck
Copy link
Contributor Author

@tobiasqueck do you want to follow-up on this one? Still seems like a reasonable adjustment to me.

I would be happy if someone takes it from here, I won't have any time over the next weeks.

@heimwege heimwege marked this pull request as ready for review July 21, 2025 15:15
@heimwege heimwege requested a review from a team as a code owner July 21, 2025 15:15
@heimwege heimwege added the backend-proxy-middleware @sap-ux/backend-proxy-middleware label Jul 21, 2025
@heimwege heimwege self-assigned this Jul 21, 2025
…e-system-access

# Conflicts:
#	packages/backend-proxy-middleware/src/base/proxy.ts
#	packages/backend-proxy-middleware/test/middleware.test.ts
#	pnpm-lock.yaml
@SAP SAP deleted a comment from sonarqubecloud bot Sep 30, 2025
Copy link

sonarqubecloud bot commented Oct 1, 2025

@IainSAP
Copy link
Contributor

IainSAP commented Oct 1, 2025

@heimwege I dont think this is needed anymore. There will be no more support for UAA authentication see: #3693

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend-proxy-middleware @sap-ux/backend-proxy-middleware

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants