Skip to content

Conversation

devinea
Copy link
Member

@devinea devinea commented Oct 9, 2025

  • add fiori_development_portal_extension.md. Improved documentation for adding a analytical chart to a odata v4 list report.
  • update README with usage rules
  • new build scripts (minify the production release).

…date README with usage rules and new build scripts
Copy link

changeset-bot bot commented Oct 9, 2025

🦋 Changeset detected

Latest commit: d03807c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sap-ux/fiori-docs-embeddings Minor
@sap-ux/fiori-mcp-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

- When creating sample data in CSV files, all primary keys and foreign keys MUST be in UUID format (e.g., `550e8400-e29b-41d4-a716-446655440001`).
- When generating or modifying the SAP Fiori elements application on top of the CAP service use the Fiori MCP server if available.
- When attempting to modify the SAP Fiori elements application like adding columns you must not use the screen personalization but instead modify the code of the project, before this first check whether an MCP server provides a suitable function.
- When previewing the SAP Fiori elements application use the most specific script for the app in the `package.json`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preview app rule already exist in line 72

Copy link
Member

@vinayhospete vinayhospete Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also add below rule to avoid project creation issues ?

  • When creating new CAP project ask cds mcp server. while using cds init, do not include any --add options (e.g., --add hana, --add sqlite, --add tiny-sample, etc.). Only use the plain form: cds init
Screenshot 2025-10-10 at 12 40 03 PM

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added. 65c6977 Thanks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not add rules to our mcp server that are basically rules for other mcp servers. That's why we did not add instructions for the cds mcp so far. In my opinion they should be added to the mcp they belong. In this case CDS. @cfg74 what do you think?

Copy link
Member Author

@devinea devinea Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heimwege
Are you referring to this:
When creating new CAP project ask cds mcp server. while using cds init, do not include any --add options (e.g., --add hana, --add sqlite, --add tiny-sample, etc.). Only use the plain form: cds init

or also

- When running CAP Node.js projects for development, you "MUST" use `cds watch` or `npm run watch-*` scripts. You "MUST NOT" use `npm start`, `npm run start`, `cds-serve`, or `cds serve` because:
  - `cds watch` provides live reload functionality
  - `npm run watch-*` scripts are optimized for development with hot reloading
  - `npm start` typically runs production builds without development features

As this one is very important for cds file changes from fiori mcp doc search responses.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was referring to all of them.

How to preview a fiori elements app is described in

When previewing the SAP Fiori elements application use the most specific script for the app in the package.json.

That rule should enforce picking the script from the generator. It uses cds watch but with --livereload false because as soon as cds livereload and our livereload middleware are running in parallel we end up in reload hell.

I thought we agreed to have only mcp specific rules with the respective mcp servers.
The changes from this pr would somehow bring fiori mcp in the position of an orchestrator that has cross mcp instructions.
Not sure if we want to do this. If we align to do so, fine for me. I just want this to be a conscious decision.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can discuss today in mcp daily. Rule to enforce cds init without sample can be dropped. I noticed today LLM creates sample bookshop app first and further replaces bookshop app with requested travel management app.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heimwege, @vinayhospete , @cfg74 Updated based on discussion.

@vinayhospete
Copy link
Member

vinayhospete commented Oct 10, 2025

Tested this PR for analytical chart, it works awesome !!!
https://github.tools.sap/ux-foundation/teched2025-CA261/tree/main/exercises/ex5

…chart_on_list_v4

* origin/main:
  chore: apply latest changesets
  chore: patch inquirer to 8.2.7 (#3689)
  chore: apply latest changesets
  fix(ui-components): UIDialog: updated interface to support multiple elements within the footer (#3715)
@devinea devinea changed the title feat(fiori-mcp-server): add fiori_development_portal_extension.md, up… feat(fiori-mcp-server): add fiori_development_portal_extension.md, etc... Oct 10, 2025
@heimwege heimwege added the fiori-mcp @sap-ux/fiori-mcp label Oct 10, 2025
devinea and others added 2 commits October 13, 2025 11:35
…chart_on_list_v4

* origin/main:
  chore: apply latest changesets
  fix: Add SAPUI5 Component Usage wizard generates file with wrong property (#3714)
  chore: apply latest changesets
  fix(ui5 library inquirer): 32726 versions sapui5 reuse libs gen (#3712)
  chore: apply latest changesets
  fix(ui5-info): EINVALs error fix (#3711)
  chore: apply latest changesets
  Feat(preview-middleware): disable flex changes for ui5 from npmjs lower than 1.84 (#3557)
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fiori-mcp @sap-ux/fiori-mcp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants