-
Notifications
You must be signed in to change notification settings - Fork 49
feat(fiori-mcp-server): add fiori_development_portal_extension.md, etc... #3717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…date README with usage rules and new build scripts
🦋 Changeset detectedLatest commit: d03807c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- When creating sample data in CSV files, all primary keys and foreign keys MUST be in UUID format (e.g., `550e8400-e29b-41d4-a716-446655440001`). | ||
- When generating or modifying the SAP Fiori elements application on top of the CAP service use the Fiori MCP server if available. | ||
- When attempting to modify the SAP Fiori elements application like adding columns you must not use the screen personalization but instead modify the code of the project, before this first check whether an MCP server provides a suitable function. | ||
- When previewing the SAP Fiori elements application use the most specific script for the app in the `package.json`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preview app rule already exist in line 72
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added. 65c6977 Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not add rules to our mcp server that are basically rules for other mcp servers. That's why we did not add instructions for the cds mcp so far. In my opinion they should be added to the mcp they belong. In this case CDS. @cfg74 what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heimwege
Are you referring to this:
When creating new CAP project ask cds mcp server. while using cds init, do not include any --add options (e.g., --add hana, --add sqlite, --add tiny-sample, etc.). Only use the plain form: cds init
or also
- When running CAP Node.js projects for development, you "MUST" use `cds watch` or `npm run watch-*` scripts. You "MUST NOT" use `npm start`, `npm run start`, `cds-serve`, or `cds serve` because:
- `cds watch` provides live reload functionality
- `npm run watch-*` scripts are optimized for development with hot reloading
- `npm start` typically runs production builds without development features
As this one is very important for cds file changes from fiori mcp doc search responses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was referring to all of them.
How to preview a fiori elements app is described in
When previewing the SAP Fiori elements application use the most specific script for the app in the package.json
.
That rule should enforce picking the script from the generator. It uses cds watch but with --livereload false because as soon as cds livereload and our livereload middleware are running in parallel we end up in reload hell.
I thought we agreed to have only mcp specific rules with the respective mcp servers.
The changes from this pr would somehow bring fiori mcp in the position of an orchestrator that has cross mcp instructions.
Not sure if we want to do this. If we align to do so, fine for me. I just want this to be a conscious decision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can discuss today in mcp daily. Rule to enforce cds init
without sample can be dropped. I noticed today LLM creates sample bookshop app first and further replaces bookshop app with requested travel management app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heimwege, @vinayhospete , @cfg74 Updated based on discussion.
Tested this PR for analytical chart, it works awesome !!! |
…chart_on_list_v4 * origin/main: chore: apply latest changesets fix: Add SAPUI5 Component Usage wizard generates file with wrong property (#3714) chore: apply latest changesets fix(ui5 library inquirer): 32726 versions sapui5 reuse libs gen (#3712) chore: apply latest changesets fix(ui5-info): EINVALs error fix (#3711) chore: apply latest changesets Feat(preview-middleware): disable flex changes for ui5 from npmjs lower than 1.84 (#3557)
|
Uh oh!
There was an error while loading. Please reload this page.