Feat: check if system has creds saved, add new messages, extend backendSystem #3720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lfindlaysap
requested changes
Oct 10, 2025
| "attemptingToExecutePostGenerationCommand": "Attempting to execute command after app generation: {{- command}}", | ||
| "installSkippedOptionSpecified": "Option `--skipInstall` was specified. Installation of dependencies will be skipped.", | ||
| "generatorExiting": "Application generation exiting due to error: {{error}}" | ||
| "generatorExiting": "Application generation exiting due to error: {{error}}", |
There was a problem hiding this comment.
Suggested change
| "generatorExiting": "Application generation exiting due to error: {{error}}", | |
| "generatorExiting": "Application generation was cancelled due to the error: {{error}}.", |
| "installSkippedOptionSpecified": "Option `--skipInstall` was specified. Installation of dependencies will be skipped.", | ||
| "generatorExiting": "Application generation exiting due to error: {{error}}" | ||
| "generatorExiting": "Application generation exiting due to error: {{error}}", | ||
| "noCredentialsBackendSystem": "No credentials found for backend system: {{system}}. Skipping storing credentials." |
There was a problem hiding this comment.
Suggested change
| "noCredentialsBackendSystem": "No credentials found for backend system: {{system}}. Skipping storing credentials." | |
| "noCredentialsBackendSystem": "No credentials were found for the back-end system: {{system}}. Skipping storing credentials." |
| "hint": "Select a system configuration.", | ||
| "message": "System", | ||
| "authenticationFailedUpdateCredentials": "Authentication failed. Please try updating the credentials." | ||
| "authenticationFailedUpdateCredentials": "Authentication failed. Please try updating the credentials.", |
There was a problem hiding this comment.
Suggested change
| "authenticationFailedUpdateCredentials": "Authentication failed. Please try updating the credentials.", | |
| "authenticationFailedUpdateCredentials": "Authentication failed. Check your credentials are correct and try again.", |
| "message": "System", | ||
| "authenticationFailedUpdateCredentials": "Authentication failed. Please try updating the credentials." | ||
| "authenticationFailedUpdateCredentials": "Authentication failed. Please try updating the credentials.", | ||
| "noStoredCredentials": "This stored system has no credentials. Please provide them. They will not be saved with system details." |
There was a problem hiding this comment.
Suggested change
| "noStoredCredentials": "This stored system has no credentials. Please provide them. They will not be saved with system details." | |
| "noStoredCredentials": "This stored system has no credentials. Please provide them. They will not be saved with the system details." |
| "checkDestinationAuthConfig": "Please check the SAP BTP destination authentication configuration.", | ||
| "choiceNameNone": "None" | ||
| "choiceNameNone": "None", | ||
| "passwordStoreWarning": "Passwords are stored in the OS credential manager and protected by its security policies." |
There was a problem hiding this comment.
Suggested change
| "passwordStoreWarning": "Passwords are stored in the OS credential manager and protected by its security policies." | |
| "passwordStoreWarning": "Passwords are stored in your operating system's credential manager and are protected by its security policies." |
|
IainSAP
reviewed
Oct 13, 2025
| // No need to await, we cannot recover anyway | ||
| // eslint-disable-next-line @typescript-eslint/no-floating-promises | ||
| storeService.write(service.backendSystem); | ||
| } else if (service.backendSystem?.newOrUpdated === false) { |
There was a problem hiding this comment.
I think this condition should be inside (service.backendSystem && hostEnv !== hostEnvironment.bas) otherwise it will always log, even on bas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3718