Light Calorimetry: Add obj for light calo objects #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version v09_19_00_01, patch release for SBN2024A
update lardataobj dependency
sbnobj v10_00_08 for sbncode v10_04_07
sbnobj v10_00_10 for sbnalg v10_05_00
sbnobj v10_01_01 for sbnalg v10_06_00_03
sbnobj v10_03_00 for sbnalg v10_11_01
Contributor
|
@lynnt20 could you nominate reviewers please? |
PetrilloAtWork
requested changes
Jan 7, 2026
Member
PetrilloAtWork
left a comment
PetrilloAtWork
left a comment
There was a problem hiding this comment.
The class version business must be fixed.
I have left also a technical C++ comment: fell completely free to decide how to approach it.
Contributor
Author
|
Hi @PetrilloAtWork, thank you for all your comments and suggestions! I believe I've implemented all the changes now: I've added the class versions and checksums for all the new classes, and also removed the value constructor (go back to "plain old data" class). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accompanying PRs: SBNSoftware/sbndcode#878, SBNSoftware/sbncode#619, SBNSoftware/sbnanaobj#181