Bookmark Sign In loading spinner #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the user experience by adding a loading spinner to the Sign In button in the Bookmark modal, providing visual feedback during the redirect to Auth0. Additionally, it includes minor cleanup of unused imports and styling adjustments.
- Added loading state (
isRedirecting) and spinner to Sign In button in Bookmark modal - Disabled button interaction during redirect with appropriate ARIA attributes
- Removed unused import and adjusted heading margin in ServerCategoryPage
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| components/Bookmark.tsx | Added isRedirecting state, disabled attribute, and Spinner component to Sign In button to show loading feedback during authentication redirect |
| app/[filename]/ServerCategoryPage.tsx | Removed unused getSanitizedBasePath import and added bottom margin to category heading |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Aibono1225
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a user clicks the Sign In button in the Bookmark modal, it takes a few seconds to redirect the user to auth0, this is because it goes through the middleware and needs to load some js. This PR adds a loading spinner to the button to let the user know something is loading.