Conversation
|
@claude PTAL |
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive Helm chart support and build tooling for deploying the supabase-operator to Kubernetes. It introduces a self-contained Helm chart with RBAC, CRDs, and configurable deployment options, along with helper scripts for building container images and managing dependencies.
Key changes:
- New Helm chart with full RBAC setup, deployment templates, and bundled CRD
- Build automation scripts for image building, commit hashing, and dependency updates
- Updated README with Helm installation and image build instructions
Reviewed Changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| image/supabase-operator/Dockerfile | Multi-stage Docker build for the operator binary |
| helm/supabase-operator/Chart.yaml | Helm chart metadata and versioning |
| helm/supabase-operator/values.yaml | Default configuration values for Helm deployment |
| helm/supabase-operator/templates/*.yaml | Kubernetes resource templates (Deployment, RBAC, Services) |
| helm/supabase-operator/templates/_helpers.tpl | Helm template helper functions |
| helm/supabase-operator/crds/*.yaml | CustomResourceDefinition for SupabaseProject |
| hack/*.sh | Build and dependency management scripts |
| Makefile | Added 'image' target for streamlined builds |
| README.md | Documentation for Helm and image building |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| HASH=$(git rev-parse --short HEAD) | ||
| if [[ $(git status --porcelain) ]]; then | ||
| HASH=${HASH}-dirty | ||
| fi |
There was a problem hiding this comment.
Line 8 contains trailing whitespace after 'fi'. While this doesn't affect functionality, it's inconsistent with shell script best practices and can cause issues with some linters or formatters.
| fi | |
| fi |
Add comprehensive Helm chart for deploying supabase-operator with: - Complete RBAC setup (ClusterRole, ServiceAccount, bindings) - Leader election and metrics collection support - Configurable deployment with values.yaml - CRD bundled in chart for self-contained installation Add build tooling in hack/ directory: - build-image.sh: BuildKit-enabled image builder with auto-tagging - commit-hash.sh: Git commit hash helper for versioning - install-setup-envtest.sh: envtest setup automation - update-kubernetes-library.sh: Kubernetes dependency updater Update Makefile with 'image' target for streamlined builds. Update README.md with Helm installation and image build instructions. Co-Authored-By: Claude <noreply@anthropic.com>
68c4fa6 to
14f7230
Compare
|
@claude review this pr please |
|
I'll analyze this and get back to you. |
|
@claude review pls |
|
Claude finished @STRRL's task —— View job PR Review
Overall: Good PR ✅ - Well-structured Helm chart and build tooling. A few items to address: Issues
Suggestions
Positive Notes
|

Add comprehensive Helm chart for deploying supabase-operator with:
Add build tooling in hack/ directory:
Update Makefile with 'image' target for streamlined builds. Update README.md with Helm installation and image build instructions.