feat(packages/sui-mono): resolve git lock errors in commit-all when running from worktrees#1977
Open
feat(packages/sui-mono): resolve git lock errors in commit-all when running from worktrees#1977
Conversation
…unning from worktrees
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
sui-mono commit-allfails withindex.lockerrors when executed from agit worktree. The root cause is that git commands within the script use inconsistent working directories —git addruns withcwdset to the package subdirectory (relative path), whilegit status,git commit, andgit resetinheritprocess.cwd()with no explicitcwd. In worktrees, this inconsistency causes git to fail when acquiring the index lock.The fix resolves the repository root once at startup via
git rev-parse --show-topleveland passes it as an explicitcwdto all git commands, ensuring they all operate on the same git index. This works correctly in both regular repos and worktrees.Related Issue
N/A
Example
Before (fails in worktrees):
After (works in both regular repos and worktrees):