Fix emoji support in comments and project descriptions#1840
Fix emoji support in comments and project descriptions#1840moio wants to merge 4 commits intoSUSE:masterfrom
Conversation
|
Hey, thanks for contributing!
Is your docker compose up? Try with |
|
Also, you need to run the migrations locally and upload the modified schema file |
|
thanks @danidoni So first of all I am trying to run rspec tests on clean App is up, but I see my emoji projects, so resetting the database. IIUC the right command is
This fails with: What am I doing wrong? |
|
I would check out master and run
`docker-compose run --rm hackweek bundle exec rake dev:bootstrap`
to start clean, as documented here: https://github.com/SUSE/hackweek?tab=readme-ov-file#hack-it
|
|
Right, thanks. Checking out from master branch, then running Checking out this branch, re-running Is it safe to assume the problem lies elsewhere? Is there anything else I should do for this PR to be mergeable? |
Co-authored-by: moio <250541+moio@users.noreply.github.com> Signed-off-by: Silvio Moioli <silvio@moioli.net>
ee6ae8b to
24d6444
Compare
|
I don't know what to tell you... I started from a fresh start, on master, and I don't have any error... Did you try removing all containers from that project and rebuild again from scratch? |
|
Just did: I get: Happy to investigate further, but I'd like some direction to do so. |
Whenever you have an error in a spec under "spec/features", rspec leaves a screenshot capturing the error that shows up in the browser inside You will find both an html dump and a png screenshot of the error. Can you go there and see what those errors are? |
|
Now rspec tests pass locally, both on main and on my branch. CI here is still broken - I see it failing to recognize the collation string. AFAIU that is caused by GHA using mysql from ubuntu packages, while the docker-compose setup uses containerized MariaDB from the latest opensuse - there is a version difference and that causes the problem. FMPOV, CI should use the same setup that devs use locally - therefore I'd say GHA should use docker-compose as well.
|
What is GHA?
To me, it makes sense yes
I would not address that in this PR, we like small focused PR's. If you feel confident enough to write another one. |
GitHub Actions
Sure. |
CI was using Ubuntu's native MySQL packages while local development uses containerized MariaDB from openSUSE via docker-compose. This version mismatch caused collation recognition failures (eg. from PR SUSE#1840). Run CI through docker compose so both environments use the same database engine and container setup. Ref: SUSE#1840 (comment) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Emojis (e.g., 😱) in comments or project descriptions cause HTTP 500. MySQL's
utf8charset only supports 3-byte UTF-8; emojis require 4-byteutf8mb4.Fixes #585.
This was made with Copilot agents as part of experiments for my HackWeek project.
I tested it manually and it works in my environment, as far as I can tell:
docker-compose exec hackweek bundle exec rspecapparently fails mid way for reasons I don’t understand. In logs I see:I hope this helps. Feedback welcome.