Open
Conversation
Clindbergh
commented
Dec 19, 2025
| for (const [peerId, value] of Object.entries(allStates)) { | ||
| if (peerId !== myPeerId) { | ||
| result.set(peerId, value) | ||
| result.set(peerId as PeerID, value) |
Contributor
Author
There was a problem hiding this comment.
This is needed because Object.entries looses types. I am a fan of ts-extras for this case.
Contributor
Author
|
I also added the use of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do you think about using the
PeerIDtype in the presence interface (instead of string)?Note
Switches presence and handle peer identifiers to the
PeerIDtype for stronger typing.PresenceInterface.peerstoMap<PeerID, ObjectValue>and update importsTypedDocHandle.peerIdandUntypedDocHandle.peerIdtypes toPeerIDUntypedDocHandlepresencepeersgetter to returnMap<PeerID, ObjectValue>(casts from entries)Written by Cursor Bugbot for commit fb7f14b. This will update automatically on new commits. Configure here.