Update code formatting with JuliaFormatter #1305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applied latest JuliaFormatter standards to improve code consistency and readability across the codebase. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
isaacsas
reviewed
Jul 31, 2025
Comment on lines
-103
to
+107
| fig, ax, hm = heatmap(x_vals, y_vals, vals[1]; | ||
| axis = (xgridvisible = false, ygridvisible = false, xlabel = "Compartment", ylabel = "Compartment"), | ||
| fig, ax, | ||
| hm = heatmap(x_vals, y_vals, vals[1]; | ||
| axis = (xgridvisible = false, ygridvisible = false, | ||
| xlabel = "Compartment", ylabel = "Compartment"), |
There was a problem hiding this comment.
Things likes this are not a reasonable reformat, and are why Catalyst no longer uses JuliaFormatter. Please revert this PR. Is this even correct syntactically now?
|
Also, why is this being merged without waiting for tests to finish? JuliaFormatter 2.0 introduced significant changes that at the time led to one or more Github issues about it breaking code. I don't think it is has proven itself to be a package we can trust to not break code functionality, so at a minimum merging mass format PRs should require an actual human review to look over the reformat and confirm tests are passing. |
|
It did pass tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code