Skip to content

Conversation

@prbzrg
Copy link
Member

@prbzrg prbzrg commented Oct 14, 2025

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Fixes #1059

@prbzrg
Copy link
Member Author

prbzrg commented Oct 19, 2025

Now, it's similar to the ODE progress logging.

for epoch in 1:epochs
if breakall
break
progress_id = uuid4()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about using a random UUID here. That as a symbol will intern. What's the reasoning?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String or symbol? because we've never used a UUID there before, at least a string one. It at least before was a symbol, and we would get memory leaks if it was unique. So check if it's always a string?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisRackauckas
Copy link
Member

Doing it the safe way but can also change in the future, this just gets it done.

@ChrisRackauckas ChrisRackauckas merged commit c08bed2 into SciML:master Oct 22, 2025
40 of 79 checks passed
@prbzrg prbzrg deleted the rw-progressbar branch October 23, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ERROR] @logprogress must be used inside @withprogress or with _id keyword argument

3 participants