Test DiffEqBase v6.177 to fix convergence failures #2863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tests if the partial revert in DiffEqBase PR SciML#1203 fixes the convergence failures in AlgConvergence_III tests that appeared after DiffEqBase PR SciML#1188. The DiffEqBase fix changes promote_f for SplitFunction to use copy instead of returning unchanged, ensuring proper cache initialization while preserving LazyBufferCache type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR bumps the DiffEqBase compat bound to v6.177 to test if PR SciML/DiffEqBase.jl#1203 fixes the convergence failures in the AlgConvergence_III tests.
Background
After DiffEqBase PR #1188, OrdinaryDiffEq started experiencing convergence rate failures in split ODE methods. The issue was traced to uninitialized cache memory in
LazyBufferCacheobjects.The Fix
DiffEqBase PR #1203 implements a partial revert that changes
promote_fforSplitFunctionto usecopyon the cache instead of returning it unchanged. This ensures proper initialization while preserving theLazyBufferCachetype structure.Testing
This PR will test if the DiffEqBase fix is sufficient to resolve the convergence failures. The CI should show whether the AlgConvergence_III tests pass with the updated dependency.
Related issues:
🤖 Generated with Claude Code