Skip to content

Conversation

@hennels
Copy link
Contributor

@hennels hennels commented Aug 27, 2025

Multiple XMP Endings

What? and Why?

Parses only the XML before the first XML end tag. Also added a test image that exhibits the issue.

The previous parser failed when given an XMP section that looked like:

<x:xmpmeta>
Normal XMP
</x:xmpmeta>
Junk data
</x:xmpmeta>

The regular expression matched the largest portion it could which would cause the XML parsing to fail when encountering the junk data. Instead we can parse only until the first ending tag to avoid the issue.

PR Checklist

  • Merged latest master
  • Updated version number

Breaking Changes

None

@hennels hennels requested a review from elliott-imhoff August 27, 2025 18:52
@hennels hennels merged commit f686835 into main Aug 29, 2025
1 check passed
@hennels hennels deleted the multiple-xmp-end-tags branch August 29, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants