Multiple Occurances of XMP End Tags #88
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple XMP Endings
What? and Why?
Parses only the XML before the first XML end tag. Also added a test image that exhibits the issue.
The previous parser failed when given an XMP section that looked like:
The regular expression matched the largest portion it could which would cause the XML parsing to fail when encountering the junk data. Instead we can parse only until the first ending tag to avoid the issue.
PR Checklist
Breaking Changes
None