-
Notifications
You must be signed in to change notification settings - Fork 5
[WS-488] [WS-954] feature/comment #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…tener; refactor ResizeToolboxItem; deprecate unused/redundant config args
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Major refactor here. Moved some event listeners to index.js in order to catch when we should ignore keypress events (ie when typing in a text box).
Also reworked the resize toolbox item to (a) erase the canvas when vanishing rather than just shrinking the annotations, and (b) be more readable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also removed the cookie that stored subtask size, since imo the configured initial_line_size should take precedence.
feature/comment
WS-488
WS-954
Description
default_keybindsargument in the configuration object. Each of the keybinds previously set bydefault_keybindscan now be set individually. Seeapi_spec.mdfor details.default_annotation_sizeargument in the configuration object. Use theinitial_line_sizeargument instead. Seeapi_spec.mdfor details.initial_line_sizeargument if provided.vanishmode to truly vanish annotations rather than just drawing them really really small. Also vanish all dialogs while vanished.PR Checklist
package.jsonhas been bumped since last releasepackage.jsonandsrc/version.jsnpm installandnpm run buildAFTER bumping the version numberapi_spec.md)changelog.mdBreaking API Changes
default_keybindsargument in the configuration object. Each of the keybinds previously set bydefault_keybindscan now be set individually. Seeapi_spec.mdfor details.default_annotation_sizeargument in the configuration object. Use theinitial_line_sizeargument instead. Seeapi_spec.mdfor details.initial_line_sizeargument takes precedence over the stored value.