Tests/LibGfx: Add a CMYK TIFF roundtrip test, and basic CMYK JPEG coverage #26344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
| { | ||
| // JPEG is lossy, so the roundtripped bitmap won't match the original bitmap. But it should still have the same size. | ||
| (void)TRY_OR_FAIL((get_roundtrip_bitmap<Gfx::JPEGWriter, Gfx::JPEGImageDecoderPlugin>(TRY_OR_FAIL(create_test_rgb_bitmap())))); | ||
| (void)TRY_OR_FAIL((get_roundtrip_bitmap<Gfx::JPEGWriter, Gfx::JPEGImageDecoderPlugin>(TRY_OR_FAIL(create_test_cmyk_bitmap())))); |
Member
There was a problem hiding this comment.
We really need to implement some sort of safety net and have these tests check against a maximal accepted error. (Your commit is fine as is, I'm just thinking out loud).
Now that we have a lossless CMYK encoder, we can add a roundtrip test for CMYK encoding :^)
Since JPEG encoding is lossy, this only checks that the image size doesn't change during a roundtrip.
This allows us to remove the CMYKBitmap overload. For CMYKBitmap, we'll always go down the `if constexpr`. Requires manually converting all NonnullRefPtrs to const refs due to the stricter type checking on templates. No behavior change.
This allows us to share one version for Bitmap and CMYKBitmap overload. Requires manually converting all NonnullRefPtrs to const refs due to the stricter type checking on templates. No behavior change.
This allows us to share one version for Bitmap and CMYKBitmap overload. Requires manually converting all NonnullRefPtrs to const refs due to the stricter type checking on templates. No behavior change.
nico
force-pushed
the
test-cmyk
branch
3 times, most recently
from
7fbb5d4 to
51c9d73
Compare
LucasChollet
approved these changes
Nov 3, 2025
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have a lossless CMYK encoder, we can add a roundtrip
test for CMYK encoding :^)
Since JPEG encoding is lossy, the JPEG test only checks that the image size
doesn't change during a roundtrip.