Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new exported RHPv4 RPC error to represent a missing/unknown contract on the host, aligning coreutils with downstream usage (e.g., hostd) per the linked issue.
Changes:
- Introduce
ErrContractNotFoundas anRPCErrorsentinel with description"contract not found". - Document the new error in
rhp/v4/errors.goalongside existing RHPv4 host errors.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lukechampine
approved these changes
Mar 18, 2026
ChrisSchinnerl
approved these changes
Mar 19, 2026
peterjan
approved these changes
Mar 19, 2026
ChrisSchinnerl
deleted the
christopher/dont-return-internal-error-contract-not-found
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: SiaFoundation/coreutils#405
Will need to update hostd to use this error instead of
go.sia.tech/hostd/host/contracts.ErrNotFound