Skip to content

syncer: Only relay peer's tip after syncing #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukechampine wants to merge 1 commit into
base: master
Choose a base branch
from
Open

syncer: Only relay peer's tip after syncing #409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/stop_relaying_sidechain_headers_after_sync.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
default: patch
---

# Fixed excessive "peer relayed a v2 header with unknown parent" log spam by only relaying headers after sync when the synced blocks became the new tip.
6 changes: 3 additions & 3 deletions syncer/syncer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,11 +717,11 @@ func (s *Syncer) syncLoop(ctx context.Context) error {
if err := s.parallelSync(ctx, r.cs, r.headers); err != nil {
s.log.Debug("sync failed", zap.Stringer("peer", r.peer), zap.Error(err))
} else if r.remaining == 0 {
// peer sent all their headers; mark as synced to avoid
// re-downloading the same blocks over and over again
// peer sent all their headers; mark them as synced and
// relay their tip
r.peer.setSynced(true)
go s.relayV2Header(r.headers[len(r.headers)-1], r.peer)
}
go s.relayV2Header(r.headers[len(r.headers)-1], r.peer)
}
}
}
Expand Down
Loading