Chore: modernize and upgrade system#22
Draft
herostrat wants to merge 4 commits intoSignalK:masterfrom
Draft
Conversation
9c1d482 to
1826365
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TBH this does a lot of things at once, but I already did the conversion and better als Draft than forgotten.
So this basically converts the code in ts, fixes problems this conversion found, adds tests for critical codepath (in my mind) and also implements basic CI to see when something regresses.
Leaving it as draft until the other stuff landed
Fixes needed for ts conversion:
useNetworkTimeaccessedoptions.preferNetworkTimewithout guardingoptions, which can throw whenstart()is called with no options.navigation.datetimemessage when options are omitted.undefinedchecks inuseNetworkTimeand call sites.options?.preferNetworkTime) and default behavior when options are not provided.validSourceswas not declared and the result fromexecSyncwas used directly in a numeric comparison.constand not converting the command output to a number.const validSources = parseInt(output.toString(), 10)and handleNaNsafely.These fixes were applied in the TypeScript version to avoid runtime errors and make the behavior deterministic.