Update Background Color Resources#252
Update Background Color Resources#252theck13 wants to merge 3 commits intoSimperium:mzorz/target-sdk-35-and-better-dark-modefrom
Conversation
|
Having a hard time trying to test your branch, I added your remote repo to my git list locally and can switch branches, but I can't see the commits listed in this PR when I fetch and pull your remote locally Tried a merge on an intermediate branch which makes things more complex since git complains both branches have unrelated history, and finally wanted to resort to cherry-pick but the commits aren't found even when pulling your branch. I may be dumb but in lack of more time to figure it out, I decided to do it the old way and applying your changes manually on my local branch, just pushed the changes to the base branch in f5dbeb1 credited your work in the commit message 🙏 Thanks much @theck13 ! |
|
Weird. I don't know what happened there either. Oh, well. Applying the changes is more important than merging this pull request. Thanks for trying multiple ways though! |
Fix
Update the background color resources created in #251 by renaming from
background_primarytobackgroundand removingbackground_secondary.Test
There are no visual changes with this update, but it be tested in Automattic/simplenote-android#1743 using the dependency below.
Review
Only one developer is required to review these changes, but anyone can perform the review.
Release
These changes do not require release notes.