fix: add missing #[serial] to config env var test#274
Merged
SimplicityGuy merged 1 commit intomainfrom Apr 4, 2026
Merged
Conversation
The test calls env::remove_var but lacked #[serial], allowing it to race with the serial test_musicbrainz_dump_url_from_env that sets the same env var — causing flaky CI failures. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
E2E Coverage (firefox)
|
Contributor
E2E Coverage (chromium)
|
Contributor
E2E Coverage (webkit)
|
Contributor
E2E Coverage (webkit - iPhone 15)
|
Contributor
E2E Coverage (webkit - iPad Pro 11)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_musicbrainz_dump_url_defaultcallsenv::remove_var("MUSICBRAINZ_DUMP_URL")but was missing#[serial], allowing it to race withtest_musicbrainz_dump_url_from_envwhich sets the same env varfrom_env()read the default URL instead of the test-set valueTest plan
config::tests::test_musicbrainz_dump_url_from_envfailure🤖 Generated with Claude Code