Skip to content

Conversation

@suerion
Copy link
Contributor

@suerion suerion commented Dec 22, 2024

Add Pull request for selection screen, try to be helpfull xD try to get from java rookie to noob ;)

@suerion suerion marked this pull request as draft December 22, 2024 13:42
@Skidamek Skidamek marked this pull request as ready for review December 22, 2024 14:21
@Skidamek Skidamek marked this pull request as draft December 22, 2024 14:23
@LilBroCodes
Copy link
Contributor

Dead pr, should probably be closed / denied

@suerion
Copy link
Contributor Author

suerion commented Mar 19, 2025

Dead pr, should probably be closed / denied

you know, whats an Draft is?

@LilBroCodes
Copy link
Contributor

Dead pr, should probably be closed / denied

you know, whats an Draft is?

Damn, sorry :/

@LilBroCodes
Copy link
Contributor

Oh crap, I just noticed that there was activity on this PR a couple days ago & in February
I just looked at the fact that it was made in last year December, and didn't see the February and March commit
Oops

suerion and others added 3 commits March 20, 2025 08:47
@suerion
Copy link
Contributor Author

suerion commented May 19, 2025

image

@Skidamek
Copy link
Owner

Skidamek commented May 22, 2025

First of all i think there should be a separate new screen after the danger screen which gives you an option to choose what packs to download.
I think we should modularize current way of creating the modpack in two ways:

  1. Reserve some name for file free to choose, on the server there would be a directory ~/automodpack/host-modpack/(free-files) - exact name yet to discuss. In this directory any file/mod which server owner places, would show up in the next new screen where player can select any of them.
  2. And now that we have reserved two folders main and the new (free-files). Server owner should be able to create any new directory inside the host-modpack which is new separate sub/modpack to the main. Where the main pack is forced to be installed, free mods are completely up to the player to install. And these sub/modpacks would have to be declared in the config as forced or optional and/or declared with which other packs this modpack is incompatible with and e.g. forced or suggested based on users operating system. If such modpack wouldn't be declared in the config, by default it would be treated as optional submodpack for player to download.

@Skidamek
Copy link
Owner

Skidamek commented May 22, 2025

Wrote a draft config scheme, that's how i imagine it https://gist.github.com/Skidamek/2d59e8addbd2b60d881b9c6213665835
It definitely won't be final, its probably flawed is someways, let me know what you think.

@Skidamek
Copy link
Owner

Started working on the topics from my previous comments in #409

@suerion
Copy link
Contributor Author

suerion commented Jul 27, 2025

Started working on the topics from my previous comments in #409

Will update the draft to the latest beta and then looking on some things.

suerion and others added 14 commits July 27, 2025 13:36
had updated with intellij, will close only pull request ;)
update beta to patch for selection screen
update to the newest prerelease
update patch1 from main
new groups update to patch
the selection screens need to change for all builds.... fabric and forge etc...

LOTS OF TODO

-> Change the DownloadSelectionScreen for all screens on different loaders
…rking again... don't know whats goint on on neoforge
@Skidamek
Copy link
Owner

thats not how git is supposed to be used...
see rebase

tbh, sorry but i dont think this pr would be helpful, its a little mess

@suerion
Copy link
Contributor Author

suerion commented Aug 28, 2025

thats not how git is supposed to be used... see rebase

tbh, sorry but i dont think this pr would be helpful, its a little mess

a little? IT IS AN BIG MESS, don't get Stonecutter running....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants