AIGEN: Fix iterator compilation bug with value class field access (#769) #1077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compiler was incorrectly marking code as unreachable when accessing fields of value classes (like Some<T>.value) if the field type appeared as unresolved type `_` during compilation. This happened with lazy iterator chains using flatMap and filter with yield. The fix moves the canInstantiate check inside the NamedLeaf branch only (for reference classes which require scalarization), allowing value class field access to proceed without this check since it's just bookkeeping. This removes the .collect(Array) workaround in SqlSchemaMigration.sk. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Contributor
Author
|
This PR was created using no other guidance than "Fix #769" |
mbouaziz
force-pushed
the
fix-769-iterator-compilation-bug
branch
from
56c71a9 to
77317fa
Compare
Contributor
Did you review it? |
Contributor
Author
|
I did review but I didn't take time to collect enough context to understand it deeply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some<T>.value) if the field type appeared as unresolved type_during compilationflatMapandfilterwithyieldcanInstantiatecheck inside theNamedLeafbranch only (for reference classes which require scalarization), allowing value class field access to proceed without this check.collect(Array)workaround in SqlSchemaMigration.skTest plan
.collect(Array)workaroundgeneric_refinement_methodtest continues to pass (regression test for the fix)Fixes #769
🤖 Generated with Claude Code