Adds interaction entity syntaxes #8291

TheMug06 · 2025-11-20T00:26:25Z

Problem

No syntax currently exists for interaction entities. SkBee used to have it, but it is disabled along with its display syntaxes in favor of Skript's.

Solution

This PR introduces several new syntaxes for each aspect of interaction entities.
Includes Height, Width, Responsiveness, Last interaction/attack date/player and a condition for responsiveness.

Testing Completed

Manually tested scripts, all syntax works locally. Can add tests if wanted :D

Supporting Information

None

Completes: none
Related: none

sovdeeth

Haven't looked at code in detail, but this is missing last attacker support

TheMug06 · 2025-11-20T01:10:38Z

Haven't looked at code in detail, but this is missing last attacker support

See ExprLastInteractionPlayer, same goes for last attack date in ExprLastInteractionDate.

sovdeeth · 2025-11-20T01:37:07Z

Haven't looked at code in detail, but this is missing last attacker support

See ExprLastInteractionPlayer, same goes for last attack date in ExprLastInteractionDate.

No, ExprLastAttacker (unless it already works?)

TheMug06 · 2025-11-20T01:39:56Z

Haven't looked at code in detail, but this is missing last attacker support

See ExprLastInteractionPlayer, same goes for last attack date in ExprLastInteractionDate.

No, ExprLastAttacker (unless it already works?)

Interaction extends Entity, so ExprLastAttacker should work fine (?). Though idk if it would due to getLastDamageCause()?

sovdeeth

lot of edits needed for code quality and conventions
requested comments don't cover everything

...ain/java/org/skriptlang/skript/bukkit/interactions/elements/conditions/CondIsResponsive.java

...va/org/skriptlang/skript/bukkit/interactions/elements/expressions/ExprInteractionHeight.java

...kriptlang/skript/bukkit/interactions/elements/expressions/ExprInteractionResponsiveness.java

Absolutionism

As per Sovde's review of following coding conventions, things I've noticed

Use SyntaxRegistry to register elements
Forgot to load the InteractionModule via main Skript class
No finals
Use @Example instead of @Examples
Each example should be in it's own @Example
One liner @Example and @Description should not be encased in {}
Inline Nullable annotation, i.e. @Nullable blah or blah @Nullable []
No 1 letter variable names
Tests
Expression change should allow changing of multiple interactions, not just one

...ain/java/org/skriptlang/skript/bukkit/interactions/elements/conditions/CondIsResponsive.java

src/main/java/org/skriptlang/skript/bukkit/interactions/InteractionModule.java

src/main/java/org/skriptlang/skript/bukkit/interactions/elements/effects/EffMakeResponsive.java

...rg/skriptlang/skript/bukkit/interactions/elements/expressions/ExprInteractionDimensions.java

.../org/skriptlang/skript/bukkit/interactions/elements/expressions/ExprLastInteractionDate.java

...rg/skriptlang/skript/bukkit/interactions/elements/expressions/ExprLastInteractionPlayer.java

…into pr/8291

APickledWalrus

Implementation/design is great, just a couple formatting/readability things.

APickledWalrus · 2025-12-23T00:31:19Z

src/main/resources/lang/default.lang

 	interaction:
 		name: interaction¦s
-		pattern: interaction[plural:s]
+		pattern: interaction([plural:s]| entit(plural:ies|y))


Might be clearer to use two separate patterns here

APickledWalrus · 2025-12-23T00:33:00Z

...ain/java/org/skriptlang/skript/bukkit/interactions/elements/conditions/CondIsResponsive.java

+	private boolean responsive;
+	@Override
+	public boolean init(Expression<?>[] exprs, int matchedPattern, Kleenean isDelayed, ParseResult parseResult) {
+		responsive = !parseResult.hasTag("unresponsive");


might make more sense to just put a parse tag on responsive rather than negating, but not a huge deal

APickledWalrus · 2025-12-23T00:35:40Z

.../org/skriptlang/skript/bukkit/interactions/elements/expressions/ExprLastInteractionDate.java

+
+	@Override
+	public @Nullable Date convert(Entity entity) {
+		if (entity instanceof Interaction interaction) {


I think a guard clause would be better here

src/main/java/ch/njol/skript/Skript.java

Adds interaction entity syntaxes

73aa6c7

TheMug06 requested a review from a team as a code owner November 20, 2025 00:26

TheMug06 added the feature Pull request adding a new feature. label Nov 20, 2025

TheMug06 requested review from Pesekjak and removed request for a team November 20, 2025 00:26

TheMug06 added the 2.14 Targeting a 2.14.X version release. label Nov 20, 2025

TheMug06 requested a review from cheeezburga November 20, 2025 00:26

sovdeeth requested changes Nov 20, 2025

View reviewed changes

skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Nov 20, 2025

Absolutionism requested changes Nov 20, 2025

View reviewed changes

skriptlang-automation bot removed the needs reviews A PR that needs additional reviews label Nov 20, 2025

Rework, clean up, and modernize + tests

c205434

sovdeeth requested a review from a team as a code owner December 14, 2025 01:27

sovdeeth requested review from UnderscoreTud and removed request for a team December 14, 2025 01:27

Merge branch 'dev/feature' into dev/interaction

a6fd991

sovdeeth approved these changes Dec 14, 2025

View reviewed changes

sovdeeth requested a review from Absolutionism December 14, 2025 01:28

sovdeeth added this to 2.14 Releases Dec 14, 2025

github-project-automation bot moved this to In Review in 2.14 Releases Dec 14, 2025

sovdeeth linked an issue Dec 14, 2025 that may be closed by this pull request

Support for interaction entities #8036

Open

1 task

Absolutionism requested changes Dec 14, 2025

View reviewed changes

sovdeeth added 3 commits December 13, 2025 20:51

requested changes

c8b3c0d

Merge branch 'dev/interaction' of https://github.com/TheMug06/Skript …

95415a2

…into pr/8291

Update ExprLastInteractionPlayer.java

caa09ba

sovdeeth requested a review from Absolutionism December 14, 2025 04:51

Absolutionism approved these changes Dec 14, 2025

View reviewed changes

github-project-automation bot moved this from In Review to Awaiting Merge in 2.14 Releases Dec 14, 2025

skriptlang-automation bot added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Dec 14, 2025

APickledWalrus approved these changes Dec 23, 2025

View reviewed changes

Merge branch 'dev/feature' into dev/interaction

ab2609e

APickledWalrus reviewed Dec 23, 2025

View reviewed changes

src/main/java/ch/njol/skript/Skript.java Outdated Show resolved Hide resolved

APickledWalrus and others added 2 commits January 1, 2026 16:56

Update src/main/java/ch/njol/skript/Skript.java

72c6480

Merge branch 'dev/feature' into dev/interaction

32cafde

APickledWalrus merged commit 230071c into SkriptLang:dev/feature Jan 1, 2026
9 checks passed

skriptlang-automation bot added the completed The issue has been fully resolved and the change will be in the next Skript update. label Jan 1, 2026

github-project-automation bot moved this from Awaiting Merge to Done - Awaiting Release in 2.14 Releases Jan 1, 2026

skriptlang-automation bot removed the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Jan 1, 2026

APickledWalrus moved this from Done - Awaiting Release to Done - Released in 2.14 Releases Jan 2, 2026

Uh oh!

Adds interaction entity syntaxes #8291

Adds interaction entity syntaxes #8291

Uh oh!

Conversation

TheMug06 commented Nov 20, 2025

Problem

Solution

Testing Completed

Supporting Information

Uh oh!

sovdeeth left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TheMug06 commented Nov 20, 2025

Uh oh!

sovdeeth commented Nov 20, 2025

Uh oh!

TheMug06 commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sovdeeth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Absolutionism left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

APickledWalrus left a comment

Choose a reason for hiding this comment

Uh oh!

APickledWalrus Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

APickledWalrus Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

APickledWalrus Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sovdeeth left a comment •

edited

Loading

TheMug06 commented Nov 20, 2025 •

edited

Loading

Absolutionism left a comment •

edited

Loading