-
Notifications
You must be signed in to change notification settings - Fork 606
add prompt travel #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
python3 generate_video_df.py --model_id ${model_id} --resolution 540P --ar_step 0 --base_num_frames 97 --num_frames 177 --overlap_history 17 --addnoise_condition 20 --offload --prompt 'A woman in a leather jacket and sunglasses riding a vintage motorcycle through a desert highway at sunset, her hair blowing wildly in the wind as the motorcycle kicks up dust, with the golden sun casting long shadows across the barren landscape.' 'A woman flies into space'
|
@yjp999 Added the --video parameter, which can be used to extend existing videos |
fix image size compatibility when Diffusion Forcing |
This is very interesting. I hope they accept your PR. |
What would make this especially complete is if the generations output the "video so far" in between chunks. Then if something crashes or we don't like a direction it took, we can abort the generation and use the --video parameter to continue from where we liked it. Right now, aborting means you don't get to see what the video in progress was. |
@pftq Thank you, the output video for each iteration has been added. |
Awesome work - that was quick and will be useful for sure. Have you checked this on a multi-gpu setup? I was testing this a bit today and had trouble there but not sure yet if it's from this or some other changes I'm also working on. Also I noticed you accidentally hardcoded the -17, so that I'm guessing should be args.overlap_history. Lastly, I think it works to use the source video dimension instead of cropping - so far I haven't seen any quality issues with using other aspect ratios like 1:1 or 4:3, so I feel if the user wanted to the default 540p dimensions, they could just apply that crop themselves before inputting the video. |
@pftq no, No multiple GPUs. btw, fixed a bug prev commit |
Alright. I'm using a multi-gpu setup so I'll try to debug a bit further and let you know. Noted on the bug fix. This line is still hardcoded -17 btw, should be -1*args.overlap_history:
|
I tested on multi-gpu and it is working great. How does it handle the case when the number of prompts is not the same as the number of extensions? Does it default to the last prompt? |
Do you mind if I merge these changes into my own fork too? These changes are extremely useful and I have a version I currently use that cleanly integrates these changes with my own (faster multi-gpu loading, batch mode etc). I can do a PR so you're credited for the work and so there's no conflict later if it your code is merged into the main repo. I do hope they merge your changes eventually - it basically puts SkyReels V2 on same level as Wan VACE and MAGI-1 feature-wise. |
@pftq it's okay. I don't mind. |
Thank you very much, it is done. Feel free to check out the combined fork some time. I think the combination makes for a greatly improved user experience: https://github.com/pftq/SkyReels-V2_Improvements/ |
really interesting, I strongly recommend this PR to be integrated into the official repo |
skip_weights=False whats the use case of this ? |
In what context? There is no skip_weights here |
I am trying to run your sample but got this error |
Different PR (maybe move the conversation here #31) |
Just checking will this extended prompt work on Skywork/SkyReels-V2-DF-1.3B-540P ? this is my hardware |
Yes, the model size doesn't affect the functionality. |
python3 generate_video_df.py --model_id ${model_id} --resolution 540P --ar_step 0 --base_num_frames 97 --num_frames 177 --overlap_history 17 --addnoise_condition 20 --offload --prompt 'A woman in a leather jacket and sunglasses riding a vintage motorcycle through a desert highway at sunset, her hair blowing wildly in the wind as the motorcycle kicks up dust, with the golden sun casting long shadows across the barren landscape.' 'A woman flies into space'
A.woman.in.a.leather.jacket.and.sunglasses.riding.a.vintage.motorcycle.through.a.desert.highway.at.s_4144992679_2025-04-21_19-40-22.mp4